Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint: enable only-new-issues for PRs #14136

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Aug 16, 2024

only-new-issues was disabled explicitly due to a bug that has since been resolved.

@jmank88 jmank88 requested review from a team as code owners August 16, 2024 16:21
momentmaker
momentmaker previously approved these changes Aug 16, 2024
@jmank88
Copy link
Contributor Author

jmank88 commented Aug 16, 2024

Why does it fail when this option is enabled? Is it attributing these issues to this PR for some reason? 😕
Edit: Maybe if the bump was separate?
Edit 2: That seems to have worked

chainchad
chainchad previously approved these changes Aug 16, 2024
@jmank88 jmank88 dismissed stale reviews from chainchad and momentmaker via c2c8d84 August 20, 2024 00:24
@jmank88 jmank88 changed the title golangci-lint: bump to latest; enable only-new-issues for PRs golangci-lint: enable only-new-issues for PRs Aug 20, 2024
@jmank88 jmank88 enabled auto-merge August 20, 2024 00:38
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jmank88 jmank88 added this pull request to the merge queue Aug 20, 2024
Merged via the queue into develop with commit 0fd7480 Aug 20, 2024
127 of 128 checks passed
@jmank88 jmank88 deleted the only-new-issues branch August 20, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants