Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support cosmos as LOOP Plugin #14180

Merged
merged 1 commit into from
Jan 22, 2025
Merged

support cosmos as LOOP Plugin #14180

merged 1 commit into from
Jan 22, 2025

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Aug 21, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88 jmank88 force-pushed the BCI-1971-cosmos-loopp branch 2 times, most recently from 1a6ece7 to 3f16e9b Compare August 21, 2024 13:07
@jmank88 jmank88 changed the title suppose cosmos as LOOP Plugin support cosmos as LOOP Plugin Aug 21, 2024
@jmank88 jmank88 force-pushed the BCI-1971-cosmos-loopp branch 9 times, most recently from 0ebbe4c to 87a3d3e Compare August 22, 2024 13:06
@jmank88 jmank88 requested a review from cfal August 22, 2024 13:18
archseer
archseer reviewed Aug 28, 2024
View reviewed changes
core/services/chainlink/relayer_factory.go
@@ -268,12 +269,12 @@ func (c CosmosFactoryConfig) Validate() error {
return err
}

func (r *RelayerFactory) NewCosmos(config CosmosFactoryConfig) (map[types.RelayID]CosmosLoopRelayerChainer, error) {
func (r *RelayerFactory) NewCosmos(config CosmosFactoryConfig) (map[types.RelayID]loop.Relayer, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this just use NewLOOPRelayer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm what do you mean? This is a 'universal' relayer factory, not just a Cosmos relayer factory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, is that a helper? Looks like we could switch to it after we remove the in-memory version?

@jmank88 jmank88 mentioned this pull request Aug 31, 2024
Merged
@jmank88 jmank88 force-pushed the BCI-1971-cosmos-loopp branch 2 times, most recently from f40291a to d3dfd79 Compare September 13, 2024 22:16
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
70.0% Coverage on New Code
4.6% Duplication on New Code

See analysis details on SonarQube

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 13, 2024
@jmank88 jmank88 removed the Stale label Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 14, 2025
@jmank88 jmank88 removed the Stale label Jan 14, 2025
@jmank88 jmank88 force-pushed the BCI-1971-cosmos-loopp branch 2 times, most recently from dd2aa2b to 1852089 Compare January 16, 2025 03:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , GolangCI Lint (core/scripts) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (.) , Core Tests (go_core_fuzz) , GolangCI Lint (integration-tests/load) , Core Tests (go_core_race_tests) , GolangCI Lint (integration-tests) , GolangCI Lint (deployment) , lint , SonarQube Scan

1. SonarQube server cannot be reached:[SonarQube Scan]

Source of Error: 
SonarQube Scan	2025-01-21T22:06:35.8743237Z ERROR: SonarQube server [http://sonarqube.public.main.prod.cldev.sh] can not be reached
SonarQube Scan	2025-01-21T22:06:35.8744823Z INFO: Total time: 0.495s
SonarQube Scan	2025-01-21T22:06:35.8982885Z ERROR: Error during SonarScanner execution
SonarQube Scan	2025-01-21T22:06:35.8991897Z org.sonarsource.scanner.api.internal.ScannerException: Unable to execute SonarScanner analysis
SonarQube Scan	2025-01-21T22:06:35.9004544Z Caused by: java.lang.IllegalStateException: Fail to get bootstrap index from server
SonarQube Scan	2025-01-21T22:06:35.9011453Z Caused by: java.lang.IllegalStateException: Status returned by url [***batch/index] is not valid: [503]
SonarQube Scan	2025-01-21T22:06:35.9012135Z 	at org.sonarsource.scanner.api.internal.ServerConnection.callUrl(ServerConnection.java:118)
SonarQube Scan	2025-01-21T22:06:35.9012804Z 	at org.sonarsource.scanner.api.internal.ServerConnection.downloadString(ServerConnection.java:99)
SonarQube Scan	2025-01-21T22:06:35.9013540Z 	at org.sonarsource.scanner.api.internal.BootstrapIndexDownloader.getIndex(BootstrapIndexDownloader.java:39)

Why: The error indicates that the SonarQube server at the specified URL cannot be reached, resulting in a 503 Service Unavailable status. This could be due to network issues, server downtime, or incorrect server URL.

Suggested fix: Verify the SonarQube server URL and ensure it is correct. Check the network connectivity and the status of the SonarQube server to ensure it is up and running.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@jmank88 jmank88 mentioned this pull request Jan 17, 2025
Merged
@jmank88 jmank88 force-pushed the BCI-1971-cosmos-loopp branch from 1852089 to 4c0a860 Compare January 21, 2025 00:45
@jmank88 jmank88 force-pushed the BCI-1971-cosmos-loopp branch 2 times, most recently from ec4a044 to 9fc7339 Compare January 21, 2025 21:07
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 force-pushed the BCI-1971-cosmos-loopp branch from 9fc7339 to 5fd9b9a Compare January 21, 2025 21:55
@jmank88 jmank88 marked this pull request as ready for review January 22, 2025 00:15
@jmank88 jmank88 requested review from a team as code owners January 22, 2025 00:15
@jmank88 jmank88 enabled auto-merge January 22, 2025 00:15
@jmank88 jmank88 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into develop with commit 7eb04ee Jan 22, 2025
177 of 180 checks passed
@jmank88 jmank88 deleted the BCI-1971-cosmos-loopp branch January 22, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-raykov pavel-raykov pavel-raykov approved these changes

@kalverra kalverra kalverra approved these changes

@samsondav samsondav samsondav approved these changes

@cfal cfal Awaiting requested review from cfal

@krehermann krehermann Awaiting requested review from krehermann krehermann is a code owner automatically assigned from smartcontractkit/foundations

@archseer archseer Awaiting requested review from archseer

@chainchad chainchad Awaiting requested review from chainchad

@skudasov skudasov Awaiting requested review from skudasov

@ilija42 ilija42 Awaiting requested review from ilija42

@calvwang9 calvwang9 Awaiting requested review from calvwang9

@krebernisak krebernisak Awaiting requested review from krebernisak

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@DylanTinianov DylanTinianov Awaiting requested review from DylanTinianov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmank88 @archseer @samsondav @kalverra @pavel-raykov