feat: link transfer mcms changesets #15512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
This reverts commit c17911e.
graham-chainlink
previously approved these changes
Dec 12, 2024
deployment/common/changeset/example/add_mint_burners_link_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Graham Goh <[email protected]>
Co-authored-by: Graham Goh <[email protected]>
# Conflicts: # deployment/common/proposalutils/propose.go # integration-tests/smoke/ccip/ccip_fee_boosting_test.go
graham-chainlink
previously approved these changes
Dec 12, 2024
graham-chainlink
previously approved these changes
Dec 12, 2024
# Conflicts: # deployment/common/changeset/state.go # deployment/common/changeset/transfer_to_mcms_with_timelock_test.go
graham-chainlink
previously approved these changes
Dec 12, 2024
connorwstein
previously approved these changes
Dec 12, 2024
ecPablo
dismissed stale reviews from connorwstein and graham-chainlink
via
7c2ecf0
connorwstein
approved these changes
Dec 13, 2024
graham-chainlink
approved these changes
Dec 13, 2024
george-dorin
pushed a commit
that referenced
this pull request
Jan 13, 2025
* feat: link transfer with timelock changeset * feat: link transfer and approval integration tests and changesets. * feat: rename files * fix: use deployment.SimTransactOpts() to get tx data * fix: link contract creation * fix: remove approval changeset, not necessary for sending directly from the owner * feat: make config accept a map of chain selectors for the proposal generation * fix: params on deploy link * fix: simplify config args by using state helper functions. * fix: use pointer for value * feat: add mint permissions and minting link changeset * Deploy call proxy instead of using deployer executor keys * inject call proxies in execution methods * skip call proxy when loading chain state * revert all changes * Revert "revert all changes" This reverts commit c17911e. * chore: rename load state funcs * feat: add mcms config flag * fix: integration tests after merging develop * fix: use contracts from states and code improvements * fix: cs deploy chain args * fix: params ccip boosting * fix: bundle mcms config into single struct * fix: add more validations for config * fix: remove startingOpCount and use proposal utils to derive it * fix: adjust variable names, remove boolean for mcms config, add constants move balance validation to Validate() function * feat: add tests for non mcms case, improve validations, and wait for tx confirmation. * feat: check valid until is in future * feat: add tests for Validate() and small validation fixes * fix: rename MaybeLoadLinkTokenState to MaybeLoadLinkTokenChainState to abstract loading state per chain * Update deployment/common/changeset/example/link_transfer.go Co-authored-by: Graham Goh <[email protected]> * fix: error handling and validations * fix: use getDeployer helper * feat: split mint burners into a separate changeset * fix: name TestMintLink on unit test * Update deployment/common/changeset/example/add_mint_burners_link.go Co-authored-by: Graham Goh <[email protected]> * Update deployment/common/changeset/example/add_mint_burners_link.go Co-authored-by: Graham Goh <[email protected]> * fix: use changeset apply for unit tests environment setup * fix: linting errors * fix: merge conflicts * fix: remove valid unit to reuse util for proposal creation --------- Co-authored-by: Akhil Chainani <[email protected]> Co-authored-by: Graham Goh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 3 new changesets to support the example changeset project. These changesets will create an mcms proposal to transfer link from the timelock address to the provided addresses. We also add 2nd changeset to grant allowances of link transfers.