Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ccip-4564 fix configure chains to be idempotent #15614

Merged
merged 9 commits into from
Dec 10, 2024
Merged

Ccip-4564 fix configure chains to be idempotent #15614

merged 9 commits into from
Dec 10, 2024

Conversation

AnieeG
Copy link
Contributor

@AnieeG AnieeG commented Dec 10, 2024

Requires

Supports

@AnieeG AnieeG requested review from a team as code owners December 10, 2024 20:08
@AnieeG AnieeG requested review from a team as code owners December 10, 2024 20:19
@AnieeG AnieeG requested a review from reductionista December 10, 2024 20:19
@github-actions GitHub Actions
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 0fbc7fe (ccip-4564-fix-configure-chains).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestInitialAddChainAppliedTwice 66.67% true true false 3 2 1 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 1m27.865s @smartcontractkit/ccip, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@AnieeG AnieeG enabled auto-merge December 10, 2024 21:27
@AnieeG AnieeG added this pull request to the merge queue Dec 10, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 10, 2024
@AnieeG
Ccip-4564 fix configure chains to be idempotent (#15614)
91192bb 
* remove deployCCIPContracts

* make configureChain idempotent

* add comments

* go mod tidy

* make test reliable
Merged via the queue into develop with commit 91192bb Dec 10, 2024
190 checks passed
@AnieeG AnieeG deleted the ccip-4564-fix-configure-chains branch December 10, 2024 23:03
george-dorin pushed a commit that referenced this pull request Jan 13, 2025
@AnieeG @george-dorin
Ccip-4564 fix configure chains to be idempotent (#15614)
14250c9 
* remove deployCCIPContracts

* make configureChain idempotent

* add comments

* go mod tidy

* make test reliable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorwstein connorwstein connorwstein approved these changes

@b-gopalswami b-gopalswami b-gopalswami approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@reductionista reductionista Awaiting requested review from reductionista reductionista is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnieeG @connorwstein @b-gopalswami