Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keystone] Standard error message for remote execution errors #15615

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Dec 10, 2024

No description provided.

@bolekk bolekk requested review from a team as code owners December 10, 2024 20:12
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

krebernisak
krebernisak previously approved these changes Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

patrickhuie19
patrickhuie19 previously approved these changes Dec 10, 2024
@bolekk bolekk dismissed stale reviews from patrickhuie19 and krebernisak via eb3b188 December 10, 2024 20:33
@bolekk bolekk force-pushed the remove_target_errors branch from e47443a to eb3b188 Compare December 10, 2024 20:33
krebernisak
krebernisak previously approved these changes Dec 10, 2024
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and a1e02be (remove_target_errors).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
Test_RemoteExecutableCapability_RandomCapabilityError 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/capabilities/remote/executable false 30ms @smartcontractkit/keystone, @smartcontractkit/capabilities-team

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

krehermann
krehermann previously approved these changes Dec 10, 2024
@bolekk bolekk added this pull request to the merge queue Dec 10, 2024
Merged via the queue into develop with commit 9c36587 Dec 10, 2024
169 of 171 checks passed
@bolekk bolekk deleted the remove_target_errors branch December 10, 2024 23:16
bolekk added a commit that referenced this pull request Dec 11, 2024
…tfix

[Keystone] Standard error message for remote execution errors (#15615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants