fix(workflow/syncer): upsert spec with existing secrets

[MStreet3]

the upsert method failed to account for the instance where secrets_id returned from an update remained the same. fix is to only update the secrets_id of the spec if the column is null.

Requires

Supports

[github-actions]

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , Flakeguard Deployment Project , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer, ubuntu-latest) , Flakey Test Detection , SonarQube Scan , Flakeguard Root Project / Report

1. Error parsing test results due to panic:

[A 1 <= 10 words sentence that describes the error]:[Run tests with flakeguard]

Source of Error:

Run tests with flakeguard	2024-12-12T14:21:11.8542194Z Error running tests: failed to parse test results: failed to attribute panic to test, using regex syncer\.(Test[^\.\(]+) on these strings:
Run tests with flakeguard	2024-12-12T14:21:11.8545419Z panic: Log in goroutine after Test_workflowRegisteredHandler/skips_fetch_if_secrets_url_is_missing has completed: 2024-12-12T14:21:11.729Z	DEBUG	CapabilitiesRegistry	capabilities/registry.go:69	get capability	{"version": "unset@unset", "id": "[email protected]"}
Run tests with flakeguard	2024-12-12T14:21:11.8547075Z 
Run tests with flakeguard	2024-12-12T14:21:11.8547309Z goroutine 498 [running]:
Run tests with flakeguard	2024-12-12T14:21:11.8548069Z testing.(*common).logDepth(0xc000ef9380, {0xc001220140, 0x9b}, 0x3)
Run tests with flakeguard	2024-12-12T14:21:11.8548891Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1029 +0x6d4
Run tests with flakeguard	2024-12-12T14:21:11.8549457Z testing.(*common).log(...)
Run tests with flakeguard	2024-12-12T14:21:11.8550066Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1011
Run tests with flakeguard	2024-12-12T14:21:11.8550888Z testing.(*common).Logf(0xc000ef9380, {0x3c921d2, 0x2}, {0xc001414a10, 0x1, 0x1})
Run tests with flakeguard	2024-12-12T14:21:11.8552200Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1062 +0xa5
Run tests with flakeguard	2024-12-12T14:21:11.8553991Z go.uber.org/zap/zaptest.TestingWriter.Write({{0x7f4cc8ad1800?, 0xc000ef9380?}, 0x0?}, {0xc001237000, 0x9c, 0x400})
Run tests with flakeguard	2024-12-12T14:21:11.8554786Z 	/home/runner/go/pkg/mod/go.uber.org/[email protected]/zaptest/logger.go:146 +0x11e
Run tests with flakeguard	2024-12-12T14:21:11.8555843Z go.uber.org/zap/zapcore.(*ioCore).Write(0xc000b79e30, {0xff, {0xc1ceda35eb78813f, 0x158e203d37, 0x592d0a0}, {0x3cb9ed8, 0x14}, {0x3cadad3, 0xe}, {0x1, ...}, ...}, ...)
Run tests with flakeguard	2024-12-12T14:21:11.8556725Z 	/home/runner/go/pkg/mod/go.uber.org/[email protected]/zapcore/core.go:99 +0x193
Run tests with flakeguard	2024-12-12T14:21:11.8557365Z go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc001225d40, {0xc0015d3700, 0x1, 0x2})
Run tests with flakeguard	2024-12-12T14:21:11.8557987Z 	/home/runner/go/pkg/mod/go.uber.org/[email protected]/zapcore/entry.go:253 +0x1f0
Run tests with flakeguard	2024-12-12T14:21:11.8558749Z go.uber.org/zap.(*SugaredLogger).log(0xc00008e808, 0xff, {0x3cadad3, 0xe}, {0x0, 0x0, 0x0}, {0xc001219ca0, 0x2, 0x2})
Run tests with flakeguard	2024-12-12T14:21:11.8559405Z 	/home/runner/go/pkg/mod/go.uber.org/[email protected]/sugar.go:355 +0x130
Run tests with flakeguard	2024-12-12T14:21:11.8559870Z go.uber.org/zap.(*SugaredLogger).Debugw(...)
Run tests with flakeguard	2024-12-12T14:21:11.8560714Z 	/home/runner/go/pkg/mod/go.uber.org/[email protected]/sugar.go:251
Run tests with flakeguard	2024-12-12T14:21:11.8562171Z github.com/smartcontractkit/chainlink/v2/core/capabilities.(*Registry).Get(0xc000bda940, {0x7f4cc8a81820?, 0x20?}, {0xc000d3c450, 0x18})
Run tests with flakeguard	2024-12-12T14:21:11.8563039Z 	/home/runner/work/chainlink/chainlink/core/capabilities/registry.go:69 +0x1e2
Run tests with flakeguard	2024-12-12T14:21:11.8563984Z github.com/smartcontractkit/chainlink/v2/core/capabilities.(*Registry).GetTrigger(0xc000bda940, {0x4397c50, 0xc00020b7c0}, {0xc000d3c450, 0x18})
Run tests with flakeguard	2024-12-12T14:21:11.8564826Z 	/home/runner/work/chainlink/chainlink/core/capabilities/registry.go:80 +0x6f
Run tests with flakeguard	2024-12-12T14:21:11.8566041Z github.com/smartcontractkit/chainlink/v2/core/services/workflows.(*Engine).resolveWorkflowCapabilities(0xc0006e3508, {0x4397c50, 0xc00020b7c0})
Run tests with flakeguard	2024-12-12T14:21:11.8566933Z 	/home/runner/work/chainlink/chainlink/core/services/workflows/engine.go:172 +0x17e
Run tests with flakeguard	2024-12-12T14:21:11.8567657Z github.com/smartcontractkit/chainlink/v2/core/services/workflows.(*Engine).init.func1()
Run tests with flakeguard	2024-12-12T14:21:11.8568357Z 	/home/runner/work/chainlink/chainlink/core/services/workflows/engine.go:322 +0x2af
Run tests with flakeguard	2024-12-12T14:21:11.8569363Z github.com/smartcontractkit/chainlink/v2/core/services/workflows.retryable({0x4397c50, 0xc00020b7c0}, {0x43bab70, 0xc000af54d0}, 0x1388, 0x0, 0xc000cf7ee0)
Run tests with flakeguard	2024-12-12T14:21:11.8570264Z 	/home/runner/work/chainlink/chainlink/core/services/workflows/retry.go:45 +0x402
Run tests with flakeguard	2024-12-12T14:21:11.8571111Z github.com/smartcontractkit/chainlink/v2/core/services/workflows.(*Engine).init(0xc0006e3508, {0x4397c50, 0xc00020b7c0})
Run tests with flakeguard	2024-12-12T14:21:11.8571899Z 	/home/runner/work/chainlink/chainlink/core/services/workflows/engine.go:313 +0x225
Run tests with flakeguard	2024-12-12T14:21:11.8572732Z created by github.com/smartcontractkit/chainlink/v2/core/services/workflows.(*Engine).Start.func1 in goroutine 386
Run tests with flakeguard	2024-12-12T14:21:11.8573498Z 	/home/runner/work/chainlink/chainlink/core/services/workflows/engine.go:153 +0x35a
Run tests with flakeguard	2024-12-12T14:21:11.8574183Z FAIL	github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer	92.634s
Run tests with flakeguard	2024-12-12T14:21:11.8574528Z 
Run tests with flakeguard	2024-12-12T14:21:11.8578774Z ##[error]Process completed with exit code 1.

Why: The error occurred because a log entry was made in a goroutine after the test Test_workflowRegisteredHandler/skips_fetch_if_secrets_url_is_missing had completed. This caused a panic, which the test runner could not attribute correctly, leading to a failure in parsing the test results.

Suggested fix: Ensure that all logging and other operations in goroutines are completed before the test ends. Use synchronization mechanisms like WaitGroup to ensure all goroutines finish their tasks before the test completes.