Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCMS owner rollback to deployer key #15672

Merged
merged 4 commits into from
Dec 13, 2024
Merged

MCMS owner rollback to deployer key #15672

merged 4 commits into from
Dec 13, 2024

Conversation

connorwstein
Copy link
Contributor

Until deployer key is renounced as an admin, support rollback. Useful for testing primarily, but also recovery if the MCMS deployment had problems.

@connorwstein connorwstein requested review from a team as code owners December 12, 2024 22:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

ecPablo
ecPablo previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@ecPablo ecPablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could be interesting to think about adding rollback concepts at the framework level. That way we could have a rollback CLI cmd that could automatically search for the corresponding rollback changeset of any func.

@connorwstein connorwstein added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2024
@connorwstein connorwstein added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2024
@connorwstein connorwstein added this pull request to the merge queue Dec 13, 2024
Merged via the queue into develop with commit 4e84600 Dec 13, 2024
172 checks passed
@connorwstein connorwstein deleted the ownership-xfer-rollback-cs branch December 13, 2024 22:06
george-dorin pushed a commit that referenced this pull request Jan 13, 2025
@connorwstein @george-dorin
MCMS owner rollback to deployer key (#15672)
830aa1c 
* Rollback test

* Fix merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnieeG AnieeG AnieeG approved these changes

@krehermann krehermann krehermann approved these changes

@graham-chainlink graham-chainlink graham-chainlink left review comments

@ecPablo ecPablo ecPablo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@connorwstein @krehermann @AnieeG @ecPablo @graham-chainlink