Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.19.1 config fix #15781

Closed
wants to merge 2 commits into from
Closed

Conversation

msuchacz-cll
Copy link
Collaborator

Requires

Supports

The OCR3 database must be scoped to each instance, not to the job,
otherwise we can restore the wrong config on node restart.
@msuchacz-cll msuchacz-cll requested review from a team as code owners December 19, 2024 19:43
@msuchacz-cll msuchacz-cll requested review from patrickhuie19 and removed request for a team December 19, 2024 19:43
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Flakeguard Deployment Project , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakey Test Detection , SonarQube Scan

1. Integer overflow conversion int -> int32: Golang Lint

Source of Error:
Golang Lint 2024-12-19T19:52:51.0636248Z ##[error]core/services/llo/delegate.go:149:56: G115: integer overflow conversion int -> int32 (gosec)
Golang Lint 2024-12-19T19:52:51.0637630Z Database: d.cfg.NewOCR3DB(int32(i)),
Golang Lint 2024-12-19T19:52:51.0638592Z ^

Why: This error occurs because the code is attempting to convert an int type to an int32 type, which can lead to an integer overflow if the value of int exceeds the range of int32.

Suggested fix: Ensure that the value being converted from int to int32 is within the range of int32 before performing the conversion. Alternatively, use an int32 type from the beginning if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants