-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump common; use log key package #15936
base: develop
Are you sure you want to change the base?
Conversation
I see you updated files related to
|
Quality Gate passedIssues Measures |
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (core/scripts) , GolangCI Lint (.) , Core Tests (go_core_tests) , GolangCI Lint (integration-tests/load) , Core Tests (go_core_tests_integration) , GolangCI Lint (integration-tests) , Core Tests (go_core_ccip_deployment_tests) , test-scripts , GolangCI Lint (deployment) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , SonarQube Scan , lint 1. Type mismatch in struct literal:go_core_race_testsSource of Error:core/capabilities/compute/transformer.go:69:17: cannot use maxMemoryMBs (variable of type int64) as uint64 value in struct literal Why: The variable Suggested fix: Convert 2. Type mismatch in struct literal:test-scriptsSource of Error:../capabilities/compute/transformer.go:69:17: cannot use maxMemoryMBs (variable of type int64) as uint64 value in struct literal Why: The variable Suggested fix: Convert 3. Type mismatch in struct literal:go_core_tests_integrationSource of Error:core/capabilities/compute/transformer.go:69:17: cannot use maxMemoryMBs (variable of type int64) as uint64 value in struct literal Why: The variable Suggested fix: Convert 4. Type mismatch in struct literal:go_core_ccip_deployment_testsSource of Error:core/capabilities/compute/transformer.go:69:17: cannot use maxMemoryMBs (variable of type int64) as uint64 value in struct literal Why: The variable Suggested fix: Convert 5. Type mismatch in struct literal:go_core_fuzzSource of Error:core/capabilities/compute/transformer.go:69:17: cannot use maxMemoryMBs (variable of type int64) as uint64 value in struct literal Why: The variable Suggested fix: Convert 6. Type mismatch in struct literal:go_core_testsSource of Error:core/capabilities/compute/transformer.go:69:17: cannot use maxMemoryMBs (variable of type int64) as uint64 value in struct literal Why: The variable Suggested fix: Convert 7. Unused variable:deploymentSource of Error:deployment/ccip/changeset/cs_active_candidate_test.go:139:3: declared and not used: block (typecheck)
deployment/ccip/changeset/cs_active_candidate_test.go:193:2: declared and not used: tokenConfig (typecheck)
deployment/ccip/changeset/cs_ccip_home_test.go:34:2: declared and not used: envNodes (typecheck)
deployment/ccip/changeset/cs_ccip_home_test.go:241:4: declared and not used: tokenConfig (typecheck)
deployment/ccip/changeset/cs_ccip_home_test.go:354:4: declared and not used: tokenConfig (typecheck)
deployment/ccip/changeset/cs_active_candidate_test.go:4:2: "math/big" imported and not used (typecheck)
deployment/ccip/changeset/cs_active_candidate_test.go:23:2: "github.com/smartcontractkit/chainlink/v2/core/logger" imported and not used (typecheck)
deployment/ccip/changeset/cs_ccip_home_test.go:4:2: "math/big" imported and not used (typecheck)
deployment/ccip/changeset/cs_ccip_home_test.go:13:2: "github.com/smartcontractkit/chainlink-ccip/chainconfig" imported and not used (typecheck)
deployment/ccip/changeset/cs_ccip_home_test.go:14:2: "github.com/smartcontractkit/chainlink-ccip/pkg/types/ccipocr3" imported as cciptypes and not used (typecheck)
deployment/ccip/changeset/cs_ccip_home_test.go:22:2: "github.com/smartcontractkit/chainlink/v2/core/logger" imported and not used (typecheck)
deployment/common/changeset/set_config_mcms_test.go:36:2: declared and not used: config (typecheck)
deployment/common/changeset/example/link_transfer_test.go:35:2: declared and not used: config (typecheck)
deployment/keystone/changeset/accept_ownership_test.go:54:2: declared and not used: timelock (typecheck)
deployment/keystone/changeset/append_node_capabilities_test.go:91:3: declared and not used: contracts (typecheck)
deployment/keystone/changeset/deploy_ocr3_test.go:276:3: declared and not used: contracts (typecheck)
deployment/keystone/changeset/update_don_test.go:114:3: declared and not used: contracts (typecheck)
deployment/keystone/changeset/internal/deploy_test.go:21:3: declared and not used: registry (typecheck)
deployment/keystone/changeset/internal/deploy_test.go:91:3: declared and not used: registry (typecheck)
deployment/keystone/changeset/internal/deploy_test.go:126:3: declared and not used: registry (typecheck) Why: Variables and imports are declared but not used in the code, leading to compilation errors. Suggested fix: Remove the unused variables and imports to clean up the code. 8. Unused variable:integration-testsSource of Error:integration-tests/smoke/ccip/ccip_usdc_test.go:53:2: declared and not used: ownerChainB (typecheck) Why: The variable Suggested fix: Remove the unused variable 9. Linter error:integration-tests/loadSource of Error:
Why: The linter failed to load package export data, which is required for analysis. Suggested fix: Ensure that the package 10. Linter error:core/scriptsSource of Error:
Why: The linter failed to load package export data, which is required for analysis. Suggested fix: Ensure that the package 11. Undefined fields and methods:.Source of Error:core/internal/cltest/cltest.go:265:38: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
core/internal/cltest/cltest.go:268:34: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
core/internal/cltest/cltest.go:281:25: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
core/internal/cltest/cltest.go:288:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
core/internal/cltest/cltest.go:290:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
core/internal/cltest/cltest.go:292:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
core/internal/cltest/cltest.go:650:12: ta.GetDB undefined (type *TestApplication has no field or method GetDB) (typecheck)
core/internal/cltest/cltest.go:657:27: ta.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
core/internal/cltest/cltest.go:658:15: ta.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
core/internal/cltest/cltest.go:686:11: ta.BasicAdminUsersORM undefined (type *TestApplication has no field or method BasicAdminUsersORM) (typecheck)
core/internal/cltest/cltest.go:708:38: ta.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
core/internal/cltest/cltest.go:727:38: ta.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
core/internal/cltest/cltest.go:1319:95: app.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
core/capabilities/integration_tests/framework/don.go:260:18: node.Stop undefined (type *capabilityNode has no field or method Stop) (typecheck)
core/capabilities/integration_tests/framework/don.go:337:15: node.AddJobV2 undefined (type *capabilityNode has no field or method AddJobV2) (typecheck)
core/capabilities/compute/cache.go:1: : # github.com/smartcontractkit/chainlink/v2/core/capabilities/compute [github.com/smartcontractkit/chainlink/v2/core/capabilities/compute.test]
core/capabilities/compute/transformer.go:69:17: cannot use maxMemoryMBs (variable of type int64) as uint64 value in struct literal (typecheck)
core/chains/evm/txmgr/broadcaster_test.go:682:100: not enough arguments in call to commonutils.JustError
have (unknown type)
want (interface{}, error) (typecheck)
core/cmd/admin_commands.go:147:12: p.Role undefined (type *AdminUsersPresenter has no field or method Role) (typecheck)
core/cmd/admin_commands.go:148:5: p.HasActiveApiToken undefined (type *AdminUsersPresenter has no field or method HasActiveApiToken) (typecheck)
core/cmd/admin_commands.go:149:5: p.CreatedAt undefined (type *AdminUsersPresenter has no field or method CreatedAt) (typecheck)
core/cmd/admin_commands.go:150:5: p.UpdatedAt undefined (type *AdminUsersPresenter has no field or method UpdatedAt) (typecheck)
core/cmd/admin_commands.go:219:29: user.Email undefined (type AdminUsersPresenter has no field or method Email) (typecheck)
core/cmd/admin_commands.go:220:75: user.Email undefined (type AdminUsersPresenter has no field or method Email) (typecheck)
core/cmd/aptos_keys_commands.go:30:5: p.PubKey undefined (type *AptosKeyPresenter has no field or method PubKey) (typecheck)
core/cmd/blocks_commands.go:100:20: p.EVMChainID undefined (type *LCAPresenter has no field or method EVMChainID) (typecheck)
core/cmd/bridge_commands.go:50:37: p.Confirmations undefined (type *BridgePresenter has no field or method Confirmations) (typecheck)
core/cmd/bridge_commands.go:57:5: p.Name undefined (type *BridgePresenter has no field or method Name) (typecheck)
core/cmd/bridge_commands.go:58:5: p.URL undefined (type *BridgePresenter has no field or method URL) (typecheck)
core/cmd/bridge_commands.go:60:5: p.OutgoingToken undefined (type *BridgePresenter has no field or method OutgoingToken) (typecheck)
core/cmd/bridge_commands.go:73:6: p.Name undefined (type BridgePresenter has no field or method Name) (typecheck)
core/cmd/bridge_commands.go:74:6: p.URL undefined (type BridgePresenter has no field or method URL) (typecheck)
core/cmd/chains_commands.go:70:20: p.GetID undefined (type *ChainPresenter has no field or method GetID) (typecheck)
core/cmd/cosmos_keys_commands.go:30:5: p.PubKey undefined (type *CosmosKeyPresenter has no field or method PubKey) (typecheck)
core/cmd/cosmos_transaction_commands.go:50:7: p.TxHash undefined (type *CosmosMsgPresenter has no field or method TxHash) (typecheck)
core/cmd/cosmos_transaction_commands.go:51:13: p.TxHash undefined (type *CosmosMsgPresenter has no field or method TxHash) (typecheck)
core/cmd/cosmos_transaction_commands.go:54:5: p.ChainID undefined (type *CosmosMsgPresenter has no field or method ChainID) (typecheck)
core/cmd/cosmos_transaction_commands.go:55:5: p.ContractID undefined (type *CosmosMsgPresenter has no field or method ContractID) (typecheck)
core/cmd/cosmos_transaction_commands.go:56:5: p.State undefined (type *CosmosMsgPresenter has no field or method State) (typecheck)
core/cmd/csa_keys_commands.go:85:5: p.PubKey undefined (type *CSAKeyPresenter has no field or method PubKey) (typecheck)
core/cmd/eth_keys_commands.go:128:7: p.EthBalance undefined (type *EthKeyPresenter has no field or method EthBalance) (typecheck)
core/cmd/eth_keys_commands.go:129:11: p.EthBalance undefined (type *EthKeyPresenter has no field or method EthBalance) (typecheck)
core/cmd/eth_keys_commands.go:132:7: p.LinkBalance undefined (type *EthKeyPresenter has no field or method LinkBalance) (typecheck)
core/cmd/eth_keys_commands.go:133:12: p.LinkBalance undefined (type *EthKeyPresenter has no field or method LinkBalance) (typecheck)
core/cmd/eth_keys_commands.go:136:7: p.MaxGasPriceWei undefined (type *EthKeyPresenter has no field or method MaxGasPriceWei) (typecheck)
core/cmd/eth_keys_commands.go:137:11: p.MaxGasPriceWei undefined (type *EthKeyPresenter has no field or method MaxGasPriceWei) (typecheck)
core/cmd/eth_keys_commands.go:140:5: p.Address undefined (type *EthKeyPresenter has no field or method Address) (typecheck)
core/cmd/eth_keys_commands.go:141:5: p.EVMChainID undefined (type *EthKeyPresenter has no field or method EVMChainID) (typecheck)
core/cmd/eth_keys_commands.go:144:23: p.Disabled undefined (type *EthKeyPresenter has no field or method Disabled) (typecheck)
core/cmd/eth_keys_commands.go:145:5: p.CreatedAt undefined (type *EthKeyPresenter has no field or method CreatedAt) (typecheck)
core/cmd/eth_keys_commands.go:146:5: p.UpdatedAt undefined (type *EthKeyPresenter has no field or method UpdatedAt) (typecheck) Why: The fields and methods referenced in the code do not exist in the respective structs or interfaces. Suggested fix: Verify the struct definitions and ensure that the fields and methods being accessed are correctly defined. If they have been renamed or removed, update the code accordingly. |
Requires