[TT-1847] ocr3 keystone por test broken #15948
Conversation
|
I see you updated files related to |
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , GolangCI Lint (.) , Core Tests (go_core_race_tests) , GolangCI Lint (integration-tests) , test-scripts , lint , SonarQube Scan 1. Linting errors in Go code: Golang Lint (integration-tests)Source of Error:##[error]integration-tests/capabilities/components/onchain/fund.go:32:10: fmt.Errorf can be replaced with errors.New (perfsprint)
return fmt.Errorf("error casting public key to ECDSA")
^
##[error]integration-tests/capabilities/components/onchain/fund.go:71:35: fmt.Sprint can be replaced with faster strconv.FormatUint (perfsprint)
ek, err := cl.ReadPrimaryETHKey(fmt.Sprint(sc.Cfg.Network.ChainID))
^
##[error]integration-tests/capabilities/components/evmcontracts/forwarder/forwarder.go:15:6: exported: type name will be used as forwarder.ForwarderInstance by other packages, and that stutters; consider calling this Instance (revive)
type ForwarderInstance struct {
^
##[error]integration-tests/capabilities/components/evmcontracts/capabilities_registry/capabilities_registry.go:1:9: var-naming: don't use an underscore in package name (revive)
package capabilities_registry
^
##[error]integration-tests/capabilities/workflow_test.go:372:29: var-naming: don't use underscores in Go names; var workflow_registryInstance should be workflowRegistryInstance (revive)
workflowRegistryAddr, tx, workflow_registryInstance, err := workflow_registry.DeployWorkflowRegistry(sc.NewTXOpts(), sc.Client)
^
##[error]integration-tests/capabilities/workflow_test.go:298:25: unnecessary conversion (unconvert)
_, err = s.Write([]byte(config))
^Why: The errors are caused by violations of Go linting rules, such as using Suggested fix: Update the code to comply with the linting rules. Replace 2. Go generate command failed: make generateSource of Error:make generate 2025-01-16T16:34:04.2054824Z error: integration-tests/load: exit status 1
make generate 2025-01-16T16:34:04.2055189Z make: CHANGELOG.md GNUmakefile LICENSE README.md SECURITY.md ccip common config_docs_test.go contracts core dashboard-lib deployment docs error_reporter_actions flake.lock flake.nix fuzz go.md go.mod go.sum integration-tests internal main.go main_test.go nix-darwin-shell-hook.sh nix.conf operator_ui package.json plugins pnpm-lock.yaml rawlog.log runlog.log shell.nix sonar-project.properties testdata tools [GNUmakefile:100: generate] Error 1Why: The Suggested fix: Investigate the specific error in the AER Report: Operator UI CI ran successfully ✅ |
| @@ -101,6 +103,27 @@ contract KeystoneFeedsConsumer is IReceiver, OwnerIsCreator { | |||
| return (report.Price, report.Timestamp); | |||
| } | |||
|
|
|||
| function getAllFeeds() external view returns (bytes32[] memory, uint224[] memory, uint32[] memory) { | |||
There was a problem hiding this comment.
why is the contract changing? implies many downstream changes to deployments and is unreasonable if the purpose of this PR is to fix a test, which is my understanding give the (limited) name and no description
There was a problem hiding this comment.
this is not a real PR, I created it share the code with other people. I added that method to figure out why I couldn't fetch the price, even though feedId seemed correct and even though the report was correctly sent to KeeperConsumer
There was a problem hiding this comment.
why?
please don't commit binary files
| ExistingHashedCapabilitiesIDs [][32]byte | ||
| } | ||
|
|
||
| func Deploy(sc *seth.Client) (*CapabilitiesRegistryInstance, error) { |
There was a problem hiding this comment.
why are we writing this code?
we have logic in chainlink/deployment/keystone to deploy contracts and manage them
| }, nil | ||
| } | ||
|
|
||
| func (cr *CapabilitiesRegistryInstance) AddCapabilities(capabilities []cr.CapabilitiesRegistryCapability) error { |
There was a problem hiding this comment.
please reuse the existing code or enhance or come up with a design were we can reuse and leverage existing work
|
Requires
Supports