Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper relative boost values #15956

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Use proper relative boost values #15956

merged 6 commits into from
Jan 20, 2025

Conversation

asoliman92
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@asoliman92 asoliman92 force-pushed the CCIP-4865-fee-boosting-hardening branch from dc1e1f5 to 12c603d Compare January 20, 2025 12:02
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@asoliman92 asoliman92 marked this pull request as ready for review January 20, 2025 15:07
@asoliman92 asoliman92 requested review from a team as code owners January 20, 2025 15:07
@asoliman92 asoliman92 enabled auto-merge January 20, 2025 15:09
makramkd
makramkd approved these changes Jan 20, 2025
View reviewed changes
integration-tests/smoke/ccip/ccip_fee_boosting_test.go
big.NewInt(100),
)
t.Log("Adjusted gas price on dest chain:", adjustedGasPriceDest)

feeQuoterCfg := changeset.DefaultFeeQuoterDestChainConfig()
// the default adds 10% to the gas price, we want to increase it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: should be 20%

@asoliman92 asoliman92 added this pull request to the merge queue Jan 20, 2025
Merged via the queue into develop with commit ef0b01a Jan 20, 2025
196 of 197 checks passed
@asoliman92 asoliman92 deleted the CCIP-4865-fee-boosting-hardening branch January 20, 2025 16:31
@makramkd makramkd mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusz-sekara mateusz-sekara mateusz-sekara approved these changes

@agusaldasoro agusaldasoro agusaldasoro approved these changes

@makramkd makramkd makramkd approved these changes

@george-dorin george-dorin Awaiting requested review from george-dorin george-dorin is a code owner automatically assigned from smartcontractkit/foundations

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asoliman92 @makramkd @agusaldasoro @mateusz-sekara