Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRE-44] Add restricted configuration; validate transformer values #15961

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

[CRE-44] Add restricted configuration; validate transformer values #15961

wants to merge 8 commits into from
+302 −44

Conversation

cedric-cordenier
Copy link
Contributor

This resolves CRE-44 using two distinct solutions:

  • Extending the onchain capability configuration to include the concept of RestrictedKeys and RestrictedConfig; these are keys and config fields that can't be set by workflow authors. This is useful for certain compute configuration which we might want to store onchain, eg. MaxMemoryMBs.
  • Source maximum values for MaxMemoryMBs, TickInterval and Timeout from the job spec and validate passed in values against this; this serves as a hard maximum on these values.

@cedric-cordenier cedric-cordenier mentioned this pull request Jan 16, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@cedric-cordenier cedric-cordenier marked this pull request as ready for review January 20, 2025 13:54
@cedric-cordenier cedric-cordenier requested review from a team as code owners January 20, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkaseman justinkaseman justinkaseman left review comments

@Atrax1 Atrax1 Awaiting requested review from Atrax1 Atrax1 is a code owner automatically assigned from smartcontractkit/foundations

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cedric-cordenier @justinkaseman