Update chainlink-solana

[DylanTinianov]

Requires

Supports

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[github-actions]

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , GolangCI Lint (.) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (integration-tests) , Core Tests (go_core_fuzz) , test-scripts , GolangCI Lint (deployment) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Missing import for solcfg.MultiNodeConfig in environment/memory/node.go:[Golang Lint (deployment)]

Source of Error:

##[error]environment/memory/node.go:420:21: undefined: solcfg.MultiNodeConfig) (typecheck)
	"github.com/smartcontractkit/chainlink/deployment/environment/memory"
	^

**Why**: The `solcfg.MultiNodeConfig` type is not defined or imported in the `environment/memory/node.go` file, causing the typecheck to fail.

Suggested fix: Ensure that the solcfg.MultiNodeConfig type is correctly defined and imported in the environment/memory/node.go file.

2. Unused variable block in cs_active_candidate_test.go:[Golang Lint (deployment)]

Source of Error:

##[error]deployment/ccip/changeset/cs_active_candidate_test.go:139:3: declared and not used: block (typecheck)
	block := latesthdr.Number.Uint64()
	^

**Why**: The variable `block` is declared but not used in the test file, causing a typecheck error.

Suggested fix: Remove the unused variable block or use it appropriately in the test.

3. Unused variable tokenConfig in cs_active_candidate_test.go:[Golang Lint (deployment)]

Source of Error:

##[error]deployment/ccip/changeset/cs_active_candidate_test.go:193:2: declared and not used: tokenConfig (typecheck)
	tokenConfig := changeset.NewTestTokenConfig(state.Chains[tenv.FeedChainSel].USDFeeds)
	^

**Why**: The variable `tokenConfig` is declared but not used in the test file, causing a typecheck error.

Suggested fix: Remove the unused variable tokenConfig or use it appropriately in the test.

4. Unused import math/big in cs_active_candidate_test.go:[Golang Lint (deployment)]

Source of Error:

##[error]deployment/ccip/changeset/cs_active_candidate_test.go:4:2: "math/big" imported and not used (typecheck)
	"math/big"
	^

**Why**: The `math/big` package is imported but not used in the test file, causing a typecheck error.

Suggested fix: Remove the unused import statement for math/big.

5. Undefined solcfg.MultiNodeConfig in config_test.go:[Golang Lint (.)]

Source of Error:

##[error]core/services/chainlink/config_test.go:174:23: undefined: solcfg.MultiNodeConfig
##[error]core/services/chainlink/config_test.go:175:24: undefined: solcfg.MultiNode
##[error]core/services/chainlink/config_test.go:202:23: undefined: solcfg.MultiNodeConfig
##[error]core/services/chainlink/config_test.go:203:24: undefined: solcfg.MultiNode
##[error]core/services/chainlink/config_test.go:769:22: undefined: solcfg.MultiNodeConfig
##[error]core/services/chainlink/config_test.go:770:23: undefined: solcfg.MultiNode (typecheck)

**Why**: The `solcfg.MultiNodeConfig` and `solcfg.MultiNode` types are not defined or imported in the `config_test.go` file, causing the typecheck to fail.

Suggested fix: Ensure that the solcfg.MultiNodeConfig and solcfg.MultiNode types are correctly defined and imported in the config_test.go file.

6. Missing module github.com/smartcontractkit/chainlink-solana/pkg/solana/client/multinode:[Core Tests (go_core_tests)]

Source of Error:

##[error]core/chains/evm/client/helpers_test.go:14:2: no required module provides package github.com/smartcontractkit/chainlink-solana/pkg/solana/client/multinode; to add it:
	go get github.com/smartcontractkit/chainlink-solana/pkg/solana/client/multinode

**Why**: The required module `github.com/smartcontractkit/chainlink-solana/pkg/solana/client/multinode` is not provided, causing the build to fail.

Suggested fix: Add the missing module by running go get github.com/smartcontractkit/chainlink-solana/pkg/solana/client/multinode.

7. Test failure due to unexpected error in TestDoc:[Core Tests (go_core_tests)]

Source of Error:

--- FAIL: TestDoc (0.01s)
cfgtest.go:19: 
	Error Trace:	/home/runner/work/chainlink/chainlink/core/services/chainlink/cfgtest/cfgtest.go:19
	 				/home/runner/work/chainlink/chainlink/core/config/docs/docs_test.go:42
	Error: 	Received unexpected error:
	 	Solana.MultiNode.NewHeadsPollInterval: nil
	Test: 	TestDoc
FAIL	github.com/smartcontractkit/chainlink/v2/core/config/docs	0.323s

**Why**: The test `TestDoc` received an unexpected error related to `Solana.MultiNode.NewHeadsPollInterval` being nil.

Suggested fix: Ensure that Solana.MultiNode.NewHeadsPollInterval is properly initialized before running the test.

8. Test failure due to mismatched expected and actual values in Test_SolanaChainsController_Show:[Core Tests (go_core_tests)]

Source of Error:

--- FAIL: Test_SolanaChainsController_Show (0.00s)
--- FAIL: Test_SolanaChainsController_Show/success (0.09s)
	Error Trace:	/home/runner/work/chainlink/chainlink/core/web/chains_controller_test.go:496
	Error: 	Not equal: 
	 	expected: "ChainID = 'Chainlink-12'\nBalancePollPeriod = '5s'\nConfirmPollPeriod = '500ms'\nOCR2CachePollPeriod = '1s'\nOCR2CacheTTL = '1m0s'\nTxTimeout = '1h0m0s'\nTxRetryTimeout = '10s'\nTxConfirmTimeout = '30s'\nTxExpirationRebroadcast = false\nTxRetentionTimeout = '0s'\nSkipPreflight = false\nCommitment = 'confirmed'\nMaxRetries = 0\nFeeEstimatorMode = 'fixed'\nComputeUnitPriceMax = 1000\nComputeUnitPriceMin = 0\nComputeUnitPriceDefault = 0\nFeeBumpPeriod = '3s'\nBlockHistoryPollPeriod = '5s'\nBlockHistorySize = 1\nComputeUnitLimitDefault = 200000\nEstimateComputeUnitLimit = false\nNodes = []\n\n[MultiNode]\nEnabled = false\nPollFailureThreshold = 5\nPollInterval = '15s'\nSelectionMode = 'PriorityLevel'\nSyncThreshold = 10\nNodeIsSyncingEnabled = false\nLeaseDuration = '1m0s'\nFinalizedBlockPollInterval = '5s'\nEnforceRepeatableRead = true\nDeathDeclarationDelay = '20s'\nNodeNoNewHeadsThreshold = '20s'\nNoNewFinalizedHeadsThreshold = '20s'\nFinalityDepth = 0\nFinalityTagEnabled = true\nFinalizedBlockOffset = 50\n"
	 	actual : "ChainID = 'Chainlink-12'\nBalancePollPeriod = '5s'\nConfirmPollPeriod = '500ms'\nOCR2CachePollPeriod = '1s'\nOCR2CacheTTL = '1m0s'\nTxTimeout = '1h0m0s'\nTxRetryTimeout = '10s'\nTxConfirmTimeout = '30s'\nTxExpirationRebroadcast = false\nTxRetentionTimeout = '0s'\nSkipPreflight = false\nCommitment = 'confirmed'\nMaxRetries = 0\nFeeEstimatorMode = 'fixed'\nComputeUnitPriceMax = 1000\nComputeUnitPriceMin = 0\nComputeUnitPriceDefault = 0\nFeeBumpPeriod = '3s'\nBlockHistoryPollPeriod = '5s'\nBlockHistorySize = 1\nComputeUnitLimitDefault = 200000\nEstimateComputeUnitLimit = false\nNodes = []\n\n[MultiNode]\nEnabled = false\nPollFailureThreshold = 5\nPollInterval = '15s'\nSelectionMode = 'PriorityLevel'\nSyncThreshold = 10\nNodeIsSyncingEnabled = false\nLeaseDuration = '1m0s'\nNewHeadsPollInterval = '5s'\nFinalizedBlockPollInterval = '5s'\nEnforceRepeatableRead = true\nDeathDeclarationDelay = '20s'\nNodeNoNewHeadsThreshold = '20s'\nNoNewFinalizedHeadsThreshold = '20s'\nFinalityDepth = 0\nFinalityTagEnabled = true\nFinalizedBlockOffset = 50\n"

**Why**: The test `Test_SolanaChainsController_Show` failed due to a mismatch between the expected and actual configuration values.

Suggested fix: Update the test to match the actual configuration values or correct the configuration values to match the expected ones.