-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using chainlink-framework/chains instead of chainlink/common. #15972
base: develop
Are you sure you want to change the base?
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
go.mod
Outdated
|
||
github.com/smartcontractkit/chainlink-framework/chains => /Users/pavelraykov/Pavel_dev/chainlink-framework/chains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/smartcontractkit/chainlink-framework/chains => /Users/pavelraykov/Pavel_dev/chainlink-framework/chains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, go.mod will have to be changed anyway with the newly committed version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can update to the PR branch commit to get CI working before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Now CI Core / Clean Go Tidy & Generate
passes!
204b994
to
d40d6e2
Compare
98768a3
to
a039317
Compare
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Quality Gate passedIssues Measures |
This PR starts using newly created module chainlink-framework/chains instead of chainlink/common. It essentially does the following steps: