Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to calculate gas deviation based on fitted curve #15977

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ogtownsend
Copy link
Collaborator

Description

  • Adds a new function DeviatesOnGasCurve() to CCIP calc to have a more flexible gas deviation threshold based on a sliding log scale
  • This new gas curve function will output larger deviation thresholds for smaller (in USD terms) gas prices, and smaller deviation thresholds for higher gas prices

Motivation

  • It doesn't provide much value to publish a gas update when the gas price changes from $0.00000001 to $0.00000004, all it does it cause us to spend more on publishing these gas updates

@ogtownsend ogtownsend requested a review from matYang January 17, 2025 22:56
@ogtownsend ogtownsend force-pushed the CCIP-4811-design-and-implement-the-deviation-curve-in-ccip-1-5 branch from 41d064d to e375627 Compare January 17, 2025 22:57
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cl-sonarqube-production
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant