Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE-3424: Add GAPv2 required repo header #15988

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

DimitriosNaikopoulos
Copy link
Contributor

This pull request introduces changes to the deployment/environment/devenv/jd.go file, focusing on the configuration and connection setup for the JD environment. The most important changes include the introduction of a new GAPConfig struct, the addition of a new interceptor for the repository, and modifications to the NewJDConnection function to accommodate these changes.

Changes to configuration:

  • Introduced a new GAPConfig struct to hold Token and Repository fields, and updated the JDConfig struct to use this new struct instead of a single GAP string.

Changes to connection setup:

  • Added a new gapRepositoryInterceptor function to handle the repository configuration in the gRPC connection.
  • Modified the NewJDConnection function to use both the gapTokenInterceptor and the new gapRepositoryInterceptor if the GAPConfig is provided and valid.

@DimitriosNaikopoulos DimitriosNaikopoulos requested review from a team as code owners January 20, 2025 13:29
@graham-chainlink graham-chainlink added this pull request to the merge queue Jan 21, 2025
Merged via the queue into develop with commit c430b5b Jan 21, 2025
172 of 173 checks passed
@graham-chainlink graham-chainlink deleted the RE-3424-add-repo-header branch January 21, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants