Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP-4320 ccip changeset parametrize #15989

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bukata-sa
Copy link
Contributor

@bukata-sa bukata-sa commented Jan 20, 2025

https://smartcontract-it.atlassian.net/browse/CCIP-4320
Parametrize CCIP changesets

  1. Move hardcoded inputs from cs_deploy_chain.go to created ContractParams input
  2. Move GasPriceDeviationPPB DAGasPriceDeviationPPB OptimisticConfirmationsin deploy_home_chain to testhelpers (used in deployment/environment/crib and in unit tests)
  3. Actualize tests

Still has constants in internal/deploy_home_chain.go but they are used as a defaults in changesets

@bukata-sa bukata-sa requested review from a team as code owners January 20, 2025 13:52
Copy link
Contributor

github-actions bot commented Jan 20, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and d6aeee8 (feature/changeset-parametrize).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestRMNCurseIdempotent 0.00% true true false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 0s @smartcontractkit/ccip, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@bukata-sa bukata-sa requested a review from a team as a code owner January 20, 2025 15:14
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and a30f932 (feature/changeset-parametrize).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestRMNCurseIdempotent 0.00% true true false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 0s @smartcontractkit/ccip, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants