-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Monad Testnet Config and Error Mapping #15993
base: develop
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,23 @@ | |||
ChainID = '10143' | |||
# finality_depth was: 0 | |||
FinalityDepth = 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did the finality committee approve the number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reached out, was going off a previous conversation I had with @fernandezlautaro regarding finality where a chain with instant finality we default to using a finality depth of 10 (example being sei). Please let me know if I should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please atleast make them aware, Max would be a good person to start with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we dont have the DF. we dont need to override all the configs inside core, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we always need to have this override. CCIP's is the option one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea but shouldn't the chainID only be enough & the rest will be picked up from the ccip defaults?
LogBroadcasterEnabled = false | ||
FinalityTagEnabled = false | ||
# finality_depth * block_time / 60 secs = < 1 min (finality time) | ||
NoNewFinalizedHeadsThreshold = '1m' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should we also set NoNewHeadsThreshold to a lower value (current 3m)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. added!
Quality Gate passedIssues Measures |
No description provided.