-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core default config for missing chains #16000
Open
stackman27
wants to merge
13
commits into
develop
Choose a base branch
from
sish/update-configs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,246
−1,392
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
24c7b86
Bumping package.json
mateusz-sekara 4dadcc4
added default config for missing chains
stackman27 d16e323
nit
stackman27 9ab9f4d
nit
stackman27 fa49da1
removed package lock json
stackman27 2533407
small linea update
stackman27 c4ed608
Merge branch 'develop' into sish/update-configs
stackman27 484586a
regen docs
stackman27 1294bfd
updated docs
stackman27 aebc933
cleanup
stackman27 833e9f0
nit
stackman27 9247319
Merge branch 'develop' into sish/update-configs
stackman27 6a70dc6
nit on docs
stackman27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
16 changes: 16 additions & 0 deletions
16
core/chains/evm/config/toml/defaults/Bitlayer_Mainnet.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
ChainID = '200901' | ||
FinalityTagEnabled = false | ||
FinalityDepth = 21 # confirmed with Bitlayer team and recommended by docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutFinality/#about-finality-at-stage-bitlayer-pos-bitlayer-mainnet-v1 | ||
|
||
[GasEstimator] | ||
Mode = 'FeeHistory' | ||
EIP1559DynamicFees = false | ||
PriceMax = '1 gwei' # DS&A recommended value | ||
PriceMin = '40 mwei' # During testing, we saw minimum gas prices ~50 mwei | ||
PriceDefault = '1 gwei' # As we set PriceMax to '1 gwei' and PriceDefault must be less than or equal to PriceMax | ||
FeeCapDefault = '1 gwei' # As we set PriceMax to '1 gwei' and FeeCapDefault must be less than or equal to PriceMax | ||
|
||
[HeadTracker] | ||
# FinalityDepth < 1k => FinalityTagBypass = false | ||
# https://smartcontract-it.atlassian.net/browse/SHIP-4078 | ||
FinalityTagBypass = false |
16 changes: 16 additions & 0 deletions
16
core/chains/evm/config/toml/defaults/Bitlayer_Testnet.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
ChainID = '200810' | ||
FinalityTagEnabled = false | ||
FinalityDepth = 21 # confirmed with Bitlayer team and recommended by docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutFinality/#about-finality-at-stage-bitlayer-pos-bitlayer-mainnet-v1 | ||
|
||
[GasEstimator] | ||
Mode='FeeHistory' | ||
EIP1559DynamicFees = false | ||
PriceMax = '1 gwei' # DS&A recommended value | ||
PriceMin = '40 mwei' # During testing, we saw minimum gas prices ~50 mwei | ||
PriceDefault = '1 gwei' # As we set PriceMax to '1 gwei' and PriceDefault must be less than or equal to PriceMax | ||
FeeCapDefault = '1 gwei' # As we set PriceMax to '1 gwei' and FeeCapDefault must be less than or equal to PriceMax | ||
|
||
[HeadTracker] | ||
# FinalityDepth < 1k => FinalityTagBypass = false | ||
# https://smartcontract-it.atlassian.net/browse/SHIP-4078 | ||
FinalityTagBypass = false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
ChainID = '21000000' | ||
FinalityTagEnabled = true | ||
ChainType = 'arbitrum' | ||
|
||
[GasEstimator] | ||
Mode = 'Arbitrum' | ||
LimitMax = 1_000_000_000 | ||
# Arbitrum uses the suggested gas price, so we don't want to place any limits on the minimum | ||
PriceMin = '0' | ||
PriceDefault = '0.1 gwei' | ||
PriceMax = '1000 gwei' | ||
|
||
[GasEstimator.DAOracle] | ||
OracleType = 'arbitrum' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
ChainID = '21000001' | ||
FinalityTagEnabled = true | ||
ChainType = 'arbitrum' | ||
|
||
[GasEstimator] | ||
Mode = 'Arbitrum' | ||
LimitMax = 1_000_000_000 | ||
# Arbitrum uses the suggested gas price, so we don't want to place any limits on the minimum | ||
PriceMin = '0' | ||
PriceDefault = '0.1 gwei' | ||
PriceMax = '1000 gwei' | ||
|
||
[GasEstimator.DAOracle] | ||
OracleType = 'arbitrum' |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
ChainID = '17000' | ||
FinalityTagEnabled = true | ||
|
||
[GasEstimator] | ||
EIP1559DynamicFees = true | ||
PriceMax = '1000 gwei' | ||
LimitDefault = 8000000 | ||
FeeCapDefault = '1000 gwei' | ||
|
||
[GasEstimator.BlockHistory] | ||
# Default is 4!?, which leads to bumpy gas prices. In CCIP | ||
# we want to smooth out the gas prices, so we increase the sample size. | ||
BlockHistorySize = 200 | ||
# The formula for FeeCap is (current block base fee * (1.125 ^ EIP1559FeeCapBufferBlocks) + tipcap) | ||
# where tipcap is managed by the block history estimators. In the context of CCIP, | ||
# the gas price is relayed to other changes for quotes so we want accurate/avg not pessimistic values. | ||
# So we set this to zero so FeeCap = baseFee + tipcap. | ||
EIP1559FeeCapBufferBlocks = 0 | ||
|
||
[NodePool] | ||
PollFailureThreshold = 2 | ||
PollInterval = '3s' |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,27 @@ | ||
ChainID = '59141' | ||
FinalityDepth = 900 | ||
NoNewHeadsThreshold = '0' | ||
FinalityTagEnabled = false | ||
FinalityDepth = 200 #3s block time ~ 20m finality based on committee decision | ||
NoNewHeadsThreshold = '0' #No empty blocks | ||
|
||
[GasEstimator] | ||
EIP1559DynamicFees = true | ||
PriceMin = '1 wei' | ||
[HeadTracker] | ||
HistoryDepth = 200 | ||
|
||
[Transactions] | ||
ResendAfterThreshold = '3m' | ||
ResendAfterThreshold = '30s' | ||
|
||
[HeadTracker] | ||
HistoryDepth = 1000 | ||
[GasEstimator] | ||
PriceMax = '2500 gwei' #higher max price to account for zkoverflow replacement txs | ||
BumpPercent = 10 | ||
BumpThreshold = 10 | ||
EIP1559DynamicFees = true | ||
FeeCapDefault = '2500 gwei' | ||
TipCapDefault = '5 gwei' | ||
TipCapMin = '1 gwei' | ||
LimitDefault = 8000000 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We shouldnt not have LimitDefault as 8M for Data feeds, this is only for ccip |
||
|
||
[GasEstimator.BlockHistory] | ||
BlockHistorySize = 200 | ||
CheckInclusionBlocks = 0 #required for AutoPurge zkoverflow replacement | ||
|
||
[Transactions.AutoPurge] | ||
Enabled = true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
core/chains/evm/config/toml/defaults/Shibarium_Mainnet.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
ChainID = '109' | ||
FinalityTagEnabled = true | ||
LinkContractAddress = '0x71052BAe71C25C78E37fD12E5ff1101A71d9018F' | ||
LogPollInterval = '1s' | ||
MinIncomingConfirmations = 5 | ||
NoNewHeadsThreshold = '30s' | ||
RPCBlockQueryDelay = 10 | ||
RPCDefaultBatchSize = 100 | ||
|
||
[Transactions] | ||
ResendAfterThreshold = '1m' | ||
|
||
[BalanceMonitor] | ||
Enabled = true | ||
|
||
[GasEstimator] | ||
EIP1559DynamicFees = true | ||
PriceDefault = '10 gwei' | ||
PriceMin = '2 gwei' | ||
BumpMin = '5 gwei' | ||
BumpThreshold = 5 | ||
PriceMax = '10000 gwei' | ||
LimitDefault = 8000000 | ||
FeeCapDefault = '10000 gwei' | ||
|
||
[GasEstimator.BlockHistory] | ||
# Default is 24, which leads to bumpy gas prices. In CCIP | ||
# we want to smooth out the gas prices, so we increase the sample size. | ||
BlockHistorySize = 200 | ||
|
||
[HeadTracker] | ||
HistoryDepth = 300 | ||
SamplingInterval = '1s' | ||
|
||
[NodePool] | ||
PollFailureThreshold = 2 | ||
PollInterval = '3s' | ||
SyncThreshold = 10 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are ccip specific configs, if moved to core, it will override with this value, not sure what config we used in the infra cluster