Update the Finalizer to reduce the frequency of heavy query #16132
+109
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimriou
reviewed
Jan 30, 2025
core/chains/evm/txmgr/finalizer.go
Outdated
| // Attempts are cached and used for subsequent fetches to reduce the load of the query. | ||
| // The attempts cache is refreshed every 3 requests. | ||
| func (f *evmFinalizer) fetchAttemptsRequiringReceiptFetch(ctx context.Context) ([]TxAttempt, error) { | ||
| f.attemptsCacheMu.Lock() |
There was a problem hiding this comment.
Probably not since the two calls that use the cache are sequential. I added it just in case there's any changes to it in the future since it's not obvious that this needs to be protected if it's called in a thread unsafe way. I'm probably getting ahead of myself though so I can remove it
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
amit-momin
force-pushed
the
fix/reduce-db-load
branch
from
0c797e3 to
e19ce6d
Compare
amit-momin
force-pushed
the
fix/reduce-db-load
branch
from
e19ce6d to
2a245f7
Compare
prashantkumar1982
approved these changes
Jan 31, 2025
DylanTinianov
approved these changes
Feb 3, 2025
|
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Increased DB load was noticed on CCIP prod testnet after upgrading to
2.20.0. The culprit was a query used by the EVM TXM Finalizer component to fetch attempts requiring receipt fetch.Changes
The Finalizer was updated to maintain an attempts cache for receipt fetch. It will only fetch attempts from the transaction store every 6 heads and use the cache every other time. This change will help reduce the frequency that the query is called to reduce the DB load.