Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1984] Use job distributor in keystone smoke test + FMS change #16169

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Jan 31, 2025

CORE:

  • allows to register gateway and standardcapabilities jobs with the FMS
  • adds integration tests for finding these two new jobs

Keystone smoke test:

  • use Job Distributor to create jobs

Unclear:

  • gateway job selection criteria
  • should we support other number types than int64, when iterating over untyped Gateway job spec?

@Tofel Tofel requested review from a team as code owners January 31, 2025 17:24
@Tofel Tofel requested a review from patrickhuie19 January 31, 2025 17:25
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Scheduled Run Frequency , Clean Go Tidy & Generate , Detect Changes , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , GolangCI Lint (.) , GolangCI Lint (integration-tests) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Test failure due to incorrect node operator ID: [go_core_ccip_deployment_tests]

Source of Error:
Run tests	2025-01-31T18:15:17.3695583Z update_nodes_test.go:505: 
Run tests	2025-01-31T18:15:17.3696588Z 	Error Trace:	/home/runner/work/chainlink/chainlink/deployment/keystone/changeset/internal/update_nodes_test.go:722
Run tests	2025-01-31T18:15:17.3698441Z 	 				/home/runner/work/chainlink/chainlink/deployment/keystone/changeset/internal/update_nodes_test.go:505
Run tests	2025-01-31T18:15:17.3699070Z 	Error: 	Not equal: 
Run tests	2025-01-31T18:15:17.3699502Z 	 	expected: 0x2
Run tests	2025-01-31T18:15:17.3700139Z 	 	actual : 0x1
Run tests	2025-01-31T18:15:17.3700738Z 	Test: 	TestUpdateNodes/twos_node,_one_shared_capability
Run tests	2025-01-31T18:15:17.3701290Z 	Messages: 	nop ID failed : expected 2, got 1

Why: The test TestUpdateNodes/twos_node,_one_shared_capability failed because the expected node operator ID was 2, but the actual ID was 1. This discrepancy indicates a potential issue in the logic that assigns or fetches node operator IDs.

Suggested fix: Review the logic in update_nodes_test.go and the related code that assigns or fetches node operator IDs. Ensure that the IDs are correctly assigned and fetched as expected by the test.

2. Linting error for using assert instead of require: [Golang Lint (.)]

Source of Error:
Golang Lint (.)	2025-01-31T18:03:23.5591518Z ##[error]core/services/job/job_orm_test.go:2441:2: require-error: for error assertions use require (testifylint)
Golang Lint (.)	2025-01-31T18:03:23.5592522Z 	assert.NoError(t, err, "failed to find gateway job by auth gateway id")
Golang Lint (.)	2025-01-31T18:03:23.5592958Z 	^

Why: The linter detected that assert.NoError was used instead of require.NoError for error assertions in the test file job_orm_test.go. The require package is recommended for error assertions as it stops the test immediately upon failure.

Suggested fix: Replace assert.NoError with require.NoError in the specified lines of job_orm_test.go.

3. Linting error for unused nolint directive: [Golang Lint (.)]

Source of Error:
Golang Lint (.)	2025-01-31T18:03:23.5609887Z ##[error]core/services/job/models.go:888:4: directive `//nolint:revive // that's how it's named in the config` is unused for linter "revive" (nolintlint)
Golang Lint (.)	2025-01-31T18:03:23.5610707Z 			//nolint:revive // that's how it's named in the config
Golang Lint (.)	2025-01-31T18:03:23.5611066Z 			^

Why: The //nolint:revive directive in models.go is not being used by the linter "revive". This indicates that the directive is either unnecessary or incorrectly specified.

Suggested fix: Remove the unused //nolint:revive directive or ensure it is correctly applied to the intended linter warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant