-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(capabilities/webapi): use a round robin selector in handler #16170
base: develop
Are you sure you want to change the base?
Conversation
rateLimiter: rateLimiter, | ||
lggr: lgger, | ||
gc: gc, | ||
gatewaySelector: NewRoundRobinSelector(gc.GatewayIDs()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MStreet3 Thinking about this a bit more -- Is this safe? It basically queries GatewayIDs once, at instantiation time; I wonder if there could be some weird races where we haven't connected to everything and so our list is shorter than it otherwise could be. Maybe it's worth passing in the list of IDs every time we make a choice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually 🤦 nvm, you can see that the size of the list doesn't change here:
for _, gw := range config.Gateways { |
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
5cbdd32
to
46bf697
Compare
46bf697
to
73722c7
Compare
Quality Gate passedIssues Measures |
This PR:
Logs below show subsequent requests for the same message ID using gateways iteratively.
Requires
Supports