chore(cre-deployments): cre-227 forwarder CS refactor

[krehermann]

CRE-227

refactors internal implementation to reduce dependencies. last refactor blocking cre-226

Requires

Supports

[krehermann]

was unused except line 28; consolidate

[github-actions]

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , GolangCI Lint (deployment) , test-scripts , lint , SonarQube Scan

1. Comment formatting issue: Golang Lint (deployment)

Source of Error:

deployment/keystone/changeset/configure_contracts.go:28:2: commentFormatting: put a space between `//` and comment text (gocritic)
	//foundForwarder = false
	^

Why: The error is caused by a comment in the code that does not follow the proper formatting convention. Specifically, there is no space between the // and the comment text.

Suggested fix: Add a space between the // and the comment text to follow the proper formatting convention.

2. Unexpected error in test: Core Tests (go_core_ccip_deployment_tests)

Source of Error:

deploy_forwarder_test.go:116: 
	Error Trace:	/home/runner/work/chainlink/chainlink/deployment/keystone/changeset/deploy_forwarder_test.go:116
	Error: 	Received unexpected error:
	 	expected MCMS operation to be non-nil
	Test: 	TestConfigureForwarders/with_mcms/nChains=1

Why: The test TestConfigureForwarders/with_mcms/nChains=1 failed because it encountered an unexpected error where an MCMS operation was expected to be non-nil but was nil.

Suggested fix: Investigate the test setup and the conditions under which the MCMS operation is expected to be non-nil. Ensure that all necessary preconditions and configurations are met before the test is executed.

3. Unexpected error in test: Core Tests (go_core_ccip_deployment_tests)

Source of Error:

deploy_forwarder_test.go:116: 
	Error Trace:	/home/runner/work/chainlink/chainlink/deployment/keystone/changeset/deploy_forwarder_test.go:116
	Error: 	Received unexpected error:
	 	expected MCMS operation to be non-nil
	Test: 	TestConfigureForwarders/with_mcms/nChains=3

Why: The test TestConfigureForwarders/with_mcms/nChains=3 failed because it encountered an unexpected error where an MCMS operation was expected to be non-nil but was nil.

Suggested fix: Similar to the previous error, investigate the test setup and the conditions under which the MCMS operation is expected to be non-nil. Ensure that all necessary preconditions and configurations are met before the test is executed.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint