Token pools CSs: add support for test router, update remote address encodings #16178
+53
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kylesmartin
commented
Jan 31, 2025
kylesmartin
commented
- Left pad remote addresses to 32 bytes
- Allow for deploying token pools with the test router
kylesmartin
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
kylesmartin
changed the title
AnieeG
approved these changes
Jan 31, 2025
| @@ -121,8 +123,14 @@ func (c DeployTokenPoolContractsConfig) Validate(env deployment.Environment) err | |||
| if !ok { | |||
| return fmt.Errorf("chain with selector %d does not exist in state", chainSelector) | |||
| } | |||
| if router := chainState.Router; router == nil { | |||
| return fmt.Errorf("missing router on %s", chain.String()) | |||
| if c.UseTestRouter { | |||
There was a problem hiding this comment.
nit : following the same name what we have for other changeset, feel free to ignore.
Suggested change
| if c.UseTestRouter { | |
| if c.IsTestRouter { |
| @@ -151,7 +159,7 @@ func DeployTokenPoolContractsChangeset(env deployment.Environment, c DeployToken | |||
| chain := env.Chains[chainSelector] | |||
| chainState := state.Chains[chainSelector] | |||
|
|
|||
| _, err := DeployTokenPool(env.Logger, chain, chainState, newAddresses, poolConfig) | |||
| _, err := DeployTokenPool(env.Logger, chain, chainState, newAddresses, poolConfig, c.UseTestRouter) | |||
There was a problem hiding this comment.
nit : probably easier to take router address as input param?
should DeployTokenPool be unexported?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.