-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add helper script to compile sol artifacts locally #16180
base: develop
Are you sure you want to change the base?
Conversation
abbrevieated output:
artifacts populated and subsequent tests pass |
echo "Cloning chainlink-ccip..." | ||
git clone https://github.com/smartcontractkit/chainlink-ccip.git "$TEMP_REPO_DIR" | ||
|
||
echo "Checking out commit $COMMIT_SHA..." | ||
cd "$TEMP_REPO_DIR" | ||
git checkout "$COMMIT_SHA" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if someone has already chainlink-ccip cloned, in that case can it accept an arg , if set it will load from that existing dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I didn't want to potentially deal with dirty local dirs or the script failing for any edge cases. Your approach is definitely faster, but the clone right now is not too bad.
Quality Gate passedIssues Measures |
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , GolangCI Lint (deployment) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , test-scripts , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan 1. Race condition detected:[Run tests]Source of Error:
Why: The Go tests detected a race condition, which indicates that there are concurrent operations in the code that are not properly synchronized, leading to unpredictable behavior. Suggested fix: Use Go's race detector to identify the specific lines of code causing the race condition and refactor the code to ensure proper synchronization, such as using mutexes or other concurrency control mechanisms. |
https://smartcontract-it.atlassian.net/browse/INTAUTO-448
Requires
Supports