chore(cre-deployment): validate ocr xmission schedule #16265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Tofel
reviewed
Feb 7, 2025
| @@ -148,6 +148,10 @@ func (c *OCR2OracleConfig) UnmarshalJSON(data []byte) error { | |||
| } | |||
|
|
|||
| func GenerateOCR3Config(cfg OracleConfig, nca []NodeKeys, secrets deployment.OCRSecrets) (OCR2OracleConfig, error) { | |||
| // the transmission schedule is very specific; arguably it should be not be a parameter | |||
| if len(cfg.TransmissionSchedule) != 1 || cfg.TransmissionSchedule[0] != len(nca) { | |||
| return OCR2OracleConfig{}, fmt.Errorf("transmission schedule must have exactly one entry, matching the len of the number of nodes want [%d], got %v", len(nca), cfg.TransmissionSchedule) | |||
There was a problem hiding this comment.
nca []NodeKeys excludes the bootstrap node, when called, right?
Tofel
approved these changes
Feb 7, 2025
Tofel
previously requested changes
Feb 7, 2025
There was a problem hiding this comment.
Looks good, but please fix the keystone test as it fails this validation:
failed to configure contracts: failed to configure OCR3 contract: failed to configure OCR3 contract for don keystone-don: failed to generate OCR3 config: transmission schedule must have exactly one entry, matching the len of the number of nodes want [4], got [1 2 3 4]
|
george-dorin
approved these changes
Feb 7, 2025
Tofel
approved these changes
Feb 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
vyzaldysanchez
approved these changes
Feb 7, 2025
karen-stepanyan
pushed a commit
that referenced
this pull request
Feb 10, 2025
* chore(cre-deployment): validate ocr xmission schedule * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate the internal OCR capability transmission schedule.
This is the schedule for capability to 'transmit' from the OCR instance to the engine.
We need this to happen right way for all nodes, so the schedule is strictly validated against the number of nodes in the OCR capability DON
Requires
Supports