Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chainlink-solana (ccip_router split) #16272

Closed
wants to merge 1 commit into from

Conversation

archseer
Copy link
Contributor

@archseer archseer commented Feb 7, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@archseer archseer force-pushed the bump-chainlink-solana branch 2 times, most recently from 446c3a3 to d55b1f4 Compare February 7, 2025 06:05
@archseer archseer force-pushed the bump-chainlink-solana branch from d55b1f4 to 461d94a Compare February 7, 2025 06:09
@archseer archseer changed the title Bump chainlink-solana Bump chainlink-solana (ccip_router split) Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

AER Report: CI Core

aer_workflow , commit , Scheduled Run Frequency , Detect Changes , Clean Go Tidy & Generate , Core Tests (go_core_tests) , GolangCI Lint (core/scripts) , test-scripts , GolangCI Lint (.) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (integration-tests/load) , Core Tests (go_core_fuzz) , GolangCI Lint (integration-tests) , Core Tests (go_core_race_tests) , GolangCI Lint (deployment) , lint , SonarQube Scan

1. Undefined function solState.FindStatePDA and too many arguments in solRouter.NewInitializeInstruction:[Golang Lint (deployment)]

Source of Error:
ccip/changeset/cs_deploy_chain.go:566:35: undefined: solState.FindStatePDA
ccip/changeset/cs_deploy_chain.go:581:3: too many arguments in call to solRouter.NewInitializeInstruction
	have (uint64, int64, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, bin.Uint128, "github.com/gagliardetto/solana-go".PublicKey, unknown type, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey)
	want (uint64, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey)

Why: The function solState.FindStatePDA is not defined, and the function solRouter.NewInitializeInstruction is called with too many arguments.

Suggested fix: Ensure that solState.FindStatePDA is defined and imported correctly. Adjust the arguments passed to solRouter.NewInitializeInstruction to match its expected parameters.

2. Declared and not used variables:[Golang Lint (deployment)]

Source of Error:
deployment/ccip/changeset/cs_accept_admin_role_test.go:19:19: declared and not used: tokens
deployment/ccip/changeset/cs_active_candidate_test.go:139:3: declared and not used: block
deployment/ccip/changeset/cs_active_candidate_test.go:193:2: declared and not used: tokenConfig
deployment/ccip/changeset/cs_ccip_home_test.go:35:2: declared and not used: envNodes
deployment/ccip/changeset/cs_ccip_home_test.go:248:4: declared and not used: tokenConfig
deployment/ccip/changeset/cs_ccip_home_test.go:365:4: declared and not used: tokenConfig
deployment/ccip/changeset/cs_configure_token_pools_test.go:132:8: missing type in composite literal
deployment/ccip/changeset/cs_configure_token_pools_test.go:156:19: declared and not used: tokens
deployment/ccip/changeset/cs_configure_token_pools_test.go:416:5: declared and not used: lockReleaseA
deployment/ccip/changeset/cs_configure_token_pools_test.go:417:5: declared and not used: burnMintA
deployment/ccip/changeset/cs_configure_token_pools_test.go:419:5: declared and not used: lockReleaseB
deployment/ccip/changeset/cs_configure_token_pools_test.go:420:5: declared and not used: burnMintB
deployment/ccip/changeset/cs_configure_token_pools_test.go:558:6: declared and not used: aType
deployment/ccip/changeset/cs_configure_token_pools_test.go:562:6: declared and not used: bType
deployment/ccip/changeset/cs_configure_token_pools_test.go:325:2: declared and not used: acceptLiquidity
deployment/ccip/changeset/cs_propose_admin_role_test.go:20:19: declared and not used: tokens

Why: Variables are declared but not used in the code, leading to linting errors.

Suggested fix: Remove the unused variables or use them appropriately in the code.

3. Import errors and undefined types/functions:[Golang Lint (integration-tests/load)]

Source of Error:
integration-tests/load/ccip/destination_gun.go:20:16: could not import github.com/smartcontractkit/chainlink/deployment/ccip/changeset (-: # github.com/smartcontractkit/chainlink/deployment/ccip/changeset
../../deployment/ccip/changeset/cs_deploy_chain.go:566:35: undefined: solState.FindStatePDA
../../deployment/ccip/changeset/cs_deploy_chain.go:581:3: too many arguments in call to solRouter.NewInitializeInstruction
	have (uint64, int64, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, bin.Uint128, "github.com/gagliardetto/solana-go".PublicKey, unknown type, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey)
	want (uint64, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey, "github.com/gagliardetto/solana-go".PublicKey)
../../deployment/ccip/changeset/cs_deploy_chain.go:674:36: undefined: solState.FindStatePDA
../../deployment/ccip/changeset/solana_state.go:82:39: undefined: solState.FindStatePDA) (typecheck)

Why: Import errors and undefined types/functions in the code.

Suggested fix: Ensure that the necessary packages are imported correctly and that all referenced types and functions are defined.

4. Test failures due to request expiration and unexpected errors:[Core Tests (go_core_tests)]

Source of Error:
endtoend_test.go:33: 
	Error Trace:	/home/runner/work/chainlink/chainlink/core/capabilities/remote/executable/endtoend_test.go:33
	 				/home/runner/work/chainlink/chainlink/core/capabilities/remote/executable/endtoend_test.go:410
	 				/home/runner/work/chainlink/chainlink/core/capabilities/remote/executable/endtoend_test.go:62
	 				/opt/hostedtoolcache/go/1.23.4/x64/src/runtime/asm_amd64.s:1700
	Error: 	Received unexpected error:
	 	error executing request: request expired by executable client
	Test: 	Test_RemoteExecutableCapability_TransmissionSchedules

Why: The test failed due to a request expiration error.

Suggested fix: Investigate the cause of the request expiration and ensure that the request is completed within the expected time frame.

5. Test failures due to mismatched expected and actual values:[Core Tests (go_core_tests)]

Source of Error:
models_test.go:258: marshaled: contractID = 'foo'
relay = 'evm'
chainID = ''
p2pv2Bootstrappers = []
ocrKeyBundleID = 'bar'
monitoringEndpoint = ''
transmitterID = 'baz'
blockchainTimeout = '0s'
contractConfigTrackerPollInterval = '1s'
contractConfigConfirmations = 1
pluginType = 'median'
captureEATelemetry = false
captureAutomationCustomTelemetry = false
allowNoBootstrappers = false

[relayConfig]
chainID = 1337
fromBlock = 42

[relayConfig.chainReader]
[relayConfig.chainReader.contracts]
[relayConfig.chainReader.contracts.median]
contractABI = "[\n {\n \"anonymous\": false,\n \"inputs\": [\n {\n \"indexed\": true,\n \"internalType\": \"address\",\n \"name\": \"requester\",\n \"type\": \"address\"\n },\n {\n \"indexed\": false,\n \"internalType\": \"bytes32\",\n \"name\": \"configDigest\",\n \"type\": \"bytes32\"\n },\n {\n \"indexed\": false,\n \"internalType\": \"uint32\",\n \"name\": \"epoch\",\n \"type\": \"uint32\"\n },\n {\n \"indexed\": false,\n \"internalType\": \"uint8\",\n \"name\": \"round\",\n \"type\": \"uint8\"\n }\n ],\n \"name\": \"RoundRequested\",\n \"type\": \"event\"\n },\n {\n \"inputs\": [],\n \"name\": \"latestTransmissionDetails\",\n \"outputs\": [\n {\n \"internalType\": \"bytes32\",\n \"name\": \"configDigest\",\n \"type\": \"bytes32\"\n },\n {\n \"internalType\": \"uint32\",\n \"name\": \"epoch\",\n \"type\": \"uint32\"\n },\n {\n \"internalType\": \"uint8\",\n \"name\": \"round\",\n \"type\": \"uint8\"\n },\n {\n \"internalType\": \"int192\",\n \"name\": \"latestAnswer_\",\n \"type\": \"int192\"\n },\n {\n \"internalType\": \"uint64\",\n \"name\": \"latestTimestamp_\",\n \"type\": \"uint64\"\n }\n ],\n \"stateMutability\": \"view\",\n \"type\": \"function\"\n }\n]\n"

[relayConfig.chainReader.contracts.median.configs]
LatestRoundRequested = "{\n \"chainSpecificName\": \"RoundRequested\",\n \"readType\": \"event\"\n}\n"
LatestTransmissionDetails = "{\n \"chainSpecificName\": \"latestTransmissionDetails\",\n \"outputModifications\": [\n {\n \"EnablePathTraverse\": false,\n \"Fields\": [\n \"LatestTimestamp_\"\n ],\n \"Type\": \"epoch to time\"\n },\n {\n \"EnablePathTraverse\": false,\n \"Fields\": {\n \"LatestAnswer_\": \"LatestAnswer\",\n \"LatestTimestamp_\": \"LatestTimestamp\"\n },\n \"Type\": \"rename\"\n }\n ]\n}\n"

[relayConfig.codec]
[relayConfig.codec.configs]
[relayConfig.codec.configs.MedianReport]
typeABI = "[\n {\n \"Name\": \"Timestamp\",\n \"Type\": \"uint32\"\n },\n {\n \"Name\": \"Observers\",\n \"Type\": \"bytes32\"\n },\n {\n \"Name\": \"Observations\",\n \"Type\": \"int192[]\"\n },\n {\n \"Name\": \"JuelsPerFeeCoin\",\n \"Type\": \"int192\"\n }\n]\n"

[onchainSigningStrategy]
strategyName = 'single-chain'

[onchainSigningStrategy.config]
evm = ''
publicKey = '0xdeadbeef'

[pluginConfig]
juelsPerFeeCoinSource = " // data source 1\n ds1 [type=bridge name=\"%s\"];\n ds1_parse [type=jsonparse path=\"data\"];\n ds1_multiply [type=multiply times=2];\n\n // data source 2\n ds2 [type=http method=GET url=\"%s\"];\n ds2_parse [type=jsonparse path=\"data\"];\n ds2_multiply [type=multiply times=2];\n\n ds1 -> ds1_parse -> ds1_multiply -> answer1;\n ds2 -> ds2_parse -> ds2_multiply -> answer1;\n\n answer1 [type=median index=0];\n"

Why: The test failed due to mismatched expected and actual values.

Suggested fix: Ensure that the expected and actual values match. Update the test case or the code to align with the expected output.

@archseer
Copy link
Contributor Author

Included into #16159

@archseer archseer closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants