Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand l2ep to new chains #3684

Merged
merged 2 commits into from
Feb 17, 2025
Merged

feat: expand l2ep to new chains #3684

merged 2 commits into from
Feb 17, 2025

Conversation

KodeyThomas
Copy link
Collaborator

Description

Expands L2EP to 4 new chains (Ink, Mantle, Unichain & Soneium)

......

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: 59a8446

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/layer2-sequencer-health-adapter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@mohamed-mehany mohamed-mehany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
A few non blocking things to follow up on:

  1. Can we please check with the teams for those chains if we have sequencer health endpoints? If they already have it, it's usually a much stronger signal for indication the chain health.
  2. Do NOPs already have dedicated RPCs for those chains? I assume yes, but we need to check as we prefer NOPs to use dedicated RPCs as opposed to public / 3P RPCs for L2EP.
  3. We can proceed to make the infra-k8s env changes for testnet with internal RPCs if we have them but not a hard requirement for testnet.

@KodeyThomas KodeyThomas merged commit da27cc8 into main Feb 17, 2025
8 checks passed
@KodeyThomas KodeyThomas deleted the kodey/l2ep-expansion branch February 17, 2025 16:55
@github-actions github-actions bot mentioned this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants