Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use gomod version for compile-mcm-contracts.sh #278

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

graham-chainlink
Copy link
Contributor

In compile-mcm-contracts.sh , we have a hardcoded version of the commit hash to checkout, there can be risk where the go mod version and this script diverge.

The updated script will use the hash coded in go.mod to checkout the right version of mcms solana program.

In `compile-mcm-contracts.sh` , we have a hardcoded version of the commit hash to checkout, there can be risk where the go mod version and this script diverge.

The updated script will use the hash coded in go.mod to checkout the right version of mcms solana program.
@graham-chainlink graham-chainlink requested a review from a team as a code owner February 3, 2025 04:13
Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: 34b516b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@gustavogama-cll gustavogama-cll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@graham-chainlink graham-chainlink added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 3f510f7 Feb 4, 2025
8 checks passed
@graham-chainlink graham-chainlink deleted the ggoh/improve-compile-script branch February 4, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants