fix: update timelock conversion logic to manage predecessors per chain instead of globally #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n selector instead of a global list of predecessors.
🦋 Changeset detectedLatest commit: 4b63200 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…y which chainID the predecessor is from.
gustavogama-cll
previously approved these changes
Feb 3, 2025
| chainMetadata.MCMAddress, | ||
| t.proposal.Delay, | ||
| t.proposal.Action, | ||
| t.predecessors[opIdx], |
There was a problem hiding this comment.
I forgot: this might panic -- specially problematic since GetOpID is public, for now.
But maybe we'll get rid of this method soon. The PR is approved so, feel free to merge as is if you're not concerned.
gustavogama-cll
approved these changes
Feb 3, 2025
|
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/[email protected] ### Minor Changes - [#276](#276) [`27b77d5`](27b77d5) Thanks [@akhilchainani](https://github.com/akhilchainani)! - Update constructors to add predecessor proposals for queuing - [#254](#254) [`aad56bd`](aad56bd) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - feat(solana): add setRoot simulator - [#279](#279) [`3287f3c`](3287f3c) Thanks [@ecPablo](https://github.com/ecPablo)! - Fix bug with multichain timelock execution with predecessors calculation ### Patch Changes - [#274](#274) [`28d52c3`](28d52c3) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix(solana): fix simulator side effect bug Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates and additions to the
timelock_executable.goand related test files to enhance functionality and improve test coverage. The key changes include the introduction of new methods for operation ID retrieval and chain-specific indexing, as well as updates to existing tests to accommodate these changes.Enhancements to
timelock_executable.go:GetOpIDmethod toTimelockExecutablefor retrieving operation IDs.GetChainSpecificIndexmethod toTimelockExecutableto determine the index of an operation within a specific chain.Updates to Tests:
Test_TimelockConverterto adjust the expected predecessors in assertions. [1] [2] [3]scheduleAndExecuteGrantRolesProposalto use the newGetOpIDmethod and validate operation completion. [1] [2]Test_TimelockExecutable_GetChainSpecificIndexto verify the chain-specific indexing functionality.Improvements to
timelock_proposal.go:Convertmethod inTimelockProposalto streamline predecessor handling and chain metadata conversion. [1] [2]Test Enhancements:
Test_TimelockProposal_Convertto include additional chain selectors and transactions, ensuring comprehensive validation of the conversion process. [1] [2] [3]