-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(e2e:timelock): execution for different chains in 1 proposal #282
Conversation
|
97e75aa
to
23e8edc
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just left 1 comment
s.ChainA.chainSelector: s.ChainA.timelockContract.Address().Hex(), s.ChainB.chainSelector: s.ChainB.timelockContract.Address().Hex(), | ||
}, | ||
|
||
Operations: []mcmtypes.BatchOperation{{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it might be worth adding more operations switching chain families, like op1ChainA, op2ChainB, op3ChainA, , op4ChainA, op5ChainB. Just to test the predecessors are being handled correctly even when indexes of the proposal don't match 1:1 with the chain predecessors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, noted I will update it with next e2e I think we can put more in there.
This pull request includes several changes to the
e2e
tests and configuration files to support a new client configuration. The most important changes involve updating the client references in various test files and adding new configuration blocks inconfig.toml
.Configuration Updates:
e2e/config.toml
: Added newevm_config_b
and corresponding output configuration. Renamed existingevm_config
toevm_config_a
to distinguish between multiple configurations. [1] [2]Client Reference Updates:
e2e/ledger/ledger_test.go
: Updated client references froms.Client
tos.ClientA
in multiple methods to use the new client configuration. [1] [2] [3] [4]e2e/tests/evm/inspection.go
: Updated client references froms.Client
tos.ClientA
in multiple methods to use the new client configuration. [1] [2] [3] [4] [5] [6]e2e/tests/evm/set_root.go
: Updated client references froms.Client
tos.ClientA
in multiple methods to use the new client configuration. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]e2e/tests/evm/timelock_inspection.go
: Updated client references froms.Client
tos.ClientA
in multiple methods to use the new client configuration. [1] [2] [3] [4] [5] [6] [7] [8]DPA-1533