Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(e2e:timelock): execution for different chains in 1 proposal #282

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

ajaskolski
Copy link
Contributor

@ajaskolski ajaskolski commented Feb 3, 2025

  • Adds support for 2 evm chains.
  • Adds new test TestExecuteProposalMultipleChains.

This pull request includes several changes to the e2e tests and configuration files to support a new client configuration. The most important changes involve updating the client references in various test files and adding new configuration blocks in config.toml.

Configuration Updates:

  • e2e/config.toml: Added new evm_config_b and corresponding output configuration. Renamed existing evm_config to evm_config_a to distinguish between multiple configurations. [1] [2]

Client Reference Updates:

DPA-1533

Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: 97e75aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ajaskolski ajaskolski force-pushed the multichain-proposal-execution-timelock branch from 97e75aa to 23e8edc Compare February 4, 2025 06:27
@cl-sonarqube-production
Copy link

@ajaskolski ajaskolski marked this pull request as ready for review February 4, 2025 06:39
@ajaskolski ajaskolski requested a review from a team as a code owner February 4, 2025 06:39
Copy link
Collaborator

@ecPablo ecPablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just left 1 comment

s.ChainA.chainSelector: s.ChainA.timelockContract.Address().Hex(), s.ChainB.chainSelector: s.ChainB.timelockContract.Address().Hex(),
},

Operations: []mcmtypes.BatchOperation{{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it might be worth adding more operations switching chain families, like op1ChainA, op2ChainB, op3ChainA, , op4ChainA, op5ChainB. Just to test the predecessors are being handled correctly even when indexes of the proposal don't match 1:1 with the chain predecessors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, noted I will update it with next e2e I think we can put more in there.

@ajaskolski ajaskolski added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit d22deb1 Feb 4, 2025
8 checks passed
@ajaskolski ajaskolski deleted the multichain-proposal-execution-timelock branch February 4, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants