feat(editor): support use tags to filter data source #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrWindlike
reviewed
Sep 6, 2023
| return result.concat(tagMap[curr]); | ||
| }, []); | ||
|
|
||
| return uniq(dataSourceIds) |
There was a problem hiding this comment.
Maybe change it to something like this to be more simple and clear:
return dataSources.filter(ds=> dataSourceIds.includes(ds.id));
tanbowensg
force-pushed
the
feat/datasource-tag
branch
from
5dc0564
to
ed0a1fd
Compare
MrWindlike
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Support categorizing DataSources using Tags.
2023-09-04.5.59.35.mov
Storage
The data is stored in the metadata of the Application Schema, look like:
To add a new Tag, you can directly modify the Schema and add a new key in the
componentsTagMapwith an[]as the value.