Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eager loading fix #18

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Eager loading fix #18

merged 1 commit into from
Sep 13, 2017

Conversation

aaronwaldon
Copy link
Contributor

Added an element query modification to allow eager loading to work with Focus Point.

Added an element query modification to allow eager loading to work with Focus Point.
@smcyr smcyr merged commit 6b73ca9 into smcyr:master Sep 13, 2017
@terryupton
Copy link

I am having issues with Eager Loading still. See these posts.
aelvan/Imager-Craft#168 (comment) and
#22

I am still trying to get to the bottom of it and understand exactly what is causing this to fallover, it seems as though it is getting a value from a previous asset or something?

Digging a little deeper into the database, I noticed two rows for the same asset.
10813 1988 31 0.07 0.17 1989 2018-04-26 20:24:39 2018-04-26 20:24:39 6bfbb940-d66e-418d-b211-6dfa6676acd3

5604 1988 9 0.01 -0.04 1989 2018-03-03 13:52:24 2018-03-03 13:52:24 f68806d6-e332-4881-b5ce-014fe2159571

I am wondering if with this fix, it is in-fact getting/selecting the wrong FocusPoint, where it has been used for a different field. Is there a way to extend this to match the right field ID?

I might be wrong in my assumption, but my PHP isn't strong enough to test or resolve.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants