fix: properly handle removed items in diff

smhg · May 6, 2014 · 8b95b68 · 8b95b68
1 parent 386723b
commit 8b95b68
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/Timespan/Collection.php b/src/Timespan/Collection.php
@@ -69,10 +69,13 @@ public function diff(Collection $collection)
                 $diff = $tmp[$i]->diff($collection[$j])->getArrayCopy();
 
                 if (empty($diff)) {
+                    // remove left item, proceed to next
                     array_splice($tmp, $i, 1);
+                    $i--;
                     $resultLength--;
+                    break;
                 } else {
-                    // replace item with first item from diff
+                    // replace left item with first item from diff
                     array_splice($tmp, $i, 1, array_splice($diff, 0, 1));
                     if (!empty($diff)) {
                         // if diff has second item, insert at right location