Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kn: enable many @IgnoreNative tests #1233

Open
wants to merge 64 commits into
base: kn-main
Choose a base branch
from
Open

kn: enable many @IgnoreNative tests #1233

wants to merge 64 commits into from

Conversation

lauzadis
Copy link
Contributor

@lauzadis lauzadis commented Feb 4, 2025

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

0marperez and others added 30 commits December 16, 2024 11:30

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@lauzadis lauzadis requested a review from ianbotsf February 6, 2025 16:06
Copy link
Contributor

@0marperez 0marperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Will you remove the toList workaround before merging?

Comment on lines +36 to +37
val clientTime = Instant.fromRfc5322("Fri, 6 Oct 2023 16:20:50 -0400")
val serverTime = Instant.fromRfc5322("Fri, 6 Oct 2023 16:20:50 -0400")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This comment has been minimized.

Copy link

github-actions bot commented Feb 6, 2025

Affected Artifacts

Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
http-test-jvm.jar 61,604 58,690 2,914 4.97%
aws-signing-default-jvm.jar 53,497 51,946 1,551 2.99%
runtime-core-jvm.jar 842,829 818,814 24,015 2.93%
crt-util-jvm.jar 21,451 20,952 499 2.38%
aws-signing-tests-jvm.jar 456,687 456,627 60 0.01%
test-suite-jvm.jar 96,930 97,206 -276 -0.28%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants