Fix s3 checksum-mode header in presigned requests
#4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update our presigned canary tests to do both PUT and GET and have extra headers included that aren't in the query string
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
force-pushed
the
landonxjames/presign-fix
branch
from
1e180e3 to
a99e8bc
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
changed the title
checksum-mode header in presigned requests
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
approved these changes
Feb 7, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes a bug reported in awslabs/aws-sdk-rust#1253 with flexible checksum headers sneaking into presigned requests.
Description
Short circuit the closure that mutates the
checksum-modeheader when we detect that we are making a presigned request.Testing
Update our presigned canary tests to do both PUT and GET and have extra headers included that aren't in the query string that will expose this issue if there is a regression.
Checklist
.changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.