Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smithy-client): add prototype chain fallback for service exception #1503

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

siddsriv
Copy link
Contributor

@siddsriv siddsriv commented Jan 13, 2025

Description of changes:
adds prototype chain check for the isInstance method for ServiceException

Testing

✓ src/client.spec.ts (7)
 ✓ src/command.spec.ts (2)
 ✓ src/create-aggregated-client.spec.ts (4)
 ✓ src/date-utils.spec.ts (155)
 ↓ src/emitWarningIfUnsupportedVersion.spec.ts (7) [skipped]
 ✓ src/exceptions.spec.ts (16)
 ✓ src/get-value-from-text-node.spec.ts (3)
 ✓ src/is-serializable-header-value.spec.ts (4)
 ✓ src/lazy-json.spec.ts (7)
 ✓ src/object-mapping.spec.ts (8)
 ✓ src/parse-utils.spec.ts (430)
 ✓ src/quote-header.spec.ts (4)
 ✓ src/ser-utils.spec.ts (4)
 ✓ src/serde-json.spec.ts (3)
 ✓ src/split-every.spec.ts (5)
 ✓ src/split-header.spec.ts (2)

 Test Files  15 passed | 1 skipped (16)
      Tests  654 passed | 7 skipped (661)
   Start at  18:40:22
   Duration  1.39s (transform 836ms, setup 0ms, collect 1.71s, tests 353ms, environment 4ms, prepare 1.94s)

If one or more of the packages in the /packages directory has been modified, be sure yarn changeset add has been run and its output has
been committed and included in this pull request. See CONTRIBUTING.md.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv siddsriv requested a review from a team as a code owner January 13, 2025 18:44
Copy link

@cpyle0819 cpyle0819 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround. Looks good.

@siddsriv siddsriv merged commit e87f2b3 into smithy-lang:main Jan 13, 2025
10 checks passed
@siddsriv siddsriv deleted the instanceof-exception-fallback branch January 13, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants