Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFA/Multi: Fix simultaneous timeouts #10311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/room-battle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -440,14 +440,14 @@ export class RoomBattleTimer {
}
let didSomething = false;
for (const player of players) {
if (!player.id) continue; // already eliminated, relevant for FFA gamesif it
if (!player.id) continue; // already eliminated in 4-player
if (player.turnSecondsLeft > 0) continue;
if (this.settings.timeoutAutoChoose && player.secondsLeft > 0 && player.knownActive) {
void this.battle.stream.write(`>${player.slot} default`);
didSomething = true;
} else {
this.battle.forfeitPlayer(player, ' lost due to inactivity.');
return true;
didSomething = true;
}
}
return didSomething;
Expand Down
Loading