-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the dependency on async-lock #59
Remove the dependency on async-lock #59
Conversation
f610163
to
bffdffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an organization we maintain an MSRV policy where the MSRV should not exceed Debian Stable's packaged version of rustc. In this case this is 1.63.0. So we need to wait before this can be merged.
(const Mutex::new and const Condvar::new are available since 1.63. That actually requires 1.68 is const VecDeque::new) |
Found a way to lower the MSRV to 1.63 by using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR removes the need for async-lock as a dependency by making the Executor initializable in a const context. This relies on the const initialization of CondVars and Mutexes, so the MSRV was bumped to 1.68.
This MSRV bump may not be acceptable, so either this PR must wait, or an alternative queue implementation needs to be chosen.