Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fastrand dependency #61

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Remove fastrand dependency #61

merged 1 commit into from
Apr 21, 2024

Conversation

james7132
Copy link
Contributor

fastrand isn't being used anywhere in the crate. This PR removes it as a required dependency.

notgull
notgull approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

fastrand was originally used by the pipe implementation back when it was inlined into this crate and not used by piper.

@notgull
Copy link
Member

notgull commented Apr 21, 2024

@james7132 Thank you for all of your contributions to smol! I have sent you an invite to the smol-rs organization. If you accept, you should be able to merge this PR.

@james7132 james7132 merged commit f6fea36 into smol-rs:master Apr 21, 2024
8 checks passed
@notgull notgull mentioned this pull request Apr 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james7132 @notgull