Update to new record builder syntax #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smores56
force-pushed
the
new-builder-syntax
branch
from
155445c to
c6ae0b6
Compare
smores56
force-pushed
the
new-builder-syntax
branch
from
4a1199b to
3b17253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves Weaver to use the new map2-based record builder syntax over the old applicative one. Once the language change PR is merged, we can merge this PR and release v0.3.0 of Weaver. We can then make a PR to update the cloned arg parsing code in the basic-cli platform.
I tested this change by successfully running all 3 examples using the code in the above PR. The functionality seems to be identical, but I'll be on the lookout for bugs.
The last thing to be done in this PR is updating documentation to match the new syntax.