Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scanner support to accept deposit return vouchers (Apps-1642, Apps-1645) #225

Conversation

Fabtron
Copy link
Collaborator

@Fabtron Fabtron commented Dec 5, 2024

Deposit return vouchers can now be scanned. This means their accepted and a matching line item is added to the shopping cart. The violation handling has been integrated to ensure that the new feature behavous correctly.

This PR does not contain any ui.

APPS-1642 / APPS-1645

How to test?

Integrate this branch into an app usinng deposit return vouchers.

Test out at least the following.

  1. Scan the top 3 items from the link and add products. Trigger the checkout once you have a positive price.
  2. Scan an item multiple times -> A violation message pops up handling the douplicated.
  3. Scan the already redeemed -> A violation message pops up handling the already redeemed.

Don't scan the zero amount or the redemption failed! We cannot handle it atm.

Definition of Done

  • Issue is linked
  • All requirements of the issue are fulfilled
  • Changelog is updated
  • Documentation is updated
  • Self-Review
  • Review with the Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified build has been tested (aka. Release Build)
  • Environments have been taken care of (Production/Staging)
  • Supported languages have been tested
  • Light-/Dark-Mode has been tested
  • Edge-Cases have been tested
  • Android API Levels have been taken care of (minSdk?)

Testing

  • Tests have been written (aka Unit-Tests, Integration-Tests, ...)

@Fabtron Fabtron changed the title Apps 1642 add scanner support for deposit voucher Add scanner support to accept deposit return vouchers (Apps-1642) Dec 5, 2024
@Fabtron Fabtron marked this pull request as ready for review December 6, 2024 07:24
@Fabtron Fabtron requested a review from cmaier December 6, 2024 07:24
@Fabtron Fabtron marked this pull request as draft December 6, 2024 08:14
@Fabtron Fabtron removed the request for review from cmaier December 6, 2024 08:56
@Fabtron Fabtron changed the title Add scanner support to accept deposit return vouchers (Apps-1642) Add scanner support to accept deposit return vouchers (Apps-1642, Apps-1645) Dec 17, 2024
@Fabtron Fabtron marked this pull request as ready for review December 17, 2024 20:19
@Fabtron Fabtron requested a review from cmaier December 17, 2024 20:19
Copy link
Contributor

@cmaier cmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvements to the functional approaches. 👍

@Fabtron Fabtron requested a review from cmaier December 19, 2024 10:53
@Fabtron Fabtron merged commit 3c9d187 into feature-deposit-return-voucher Dec 19, 2024
1 check passed
@Fabtron Fabtron deleted the apps-1642-add-scanner-support-for-deposit-voucher branch December 19, 2024 11:19
@Fabtron Fabtron mentioned this pull request Dec 19, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants