-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scanner support to accept deposit return vouchers (Apps-1642, Apps-1645) #225
Merged
Fabtron
merged 44 commits into
feature-deposit-return-voucher
from
apps-1642-add-scanner-support-for-deposit-voucher
Dec 19, 2024
Merged
Add scanner support to accept deposit return vouchers (Apps-1642, Apps-1645) #225
Fabtron
merged 44 commits into
feature-deposit-return-voucher
from
apps-1642-add-scanner-support-for-deposit-voucher
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner-support-for-deposit-voucher
…r-deposit-voucher' into apps-1642-add-scanner-support-for-deposit-voucher
cmaier
suggested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some improvements to the functional approaches. 👍
...ain/java/io/snabble/sdk/codes/templates/depositReturnVoucher/DepositReturnVoucherProvider.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/io/snabble/sdk/shoppingcart/ShoppingCartUpdater.kt
Outdated
Show resolved
Hide resolved
ui/src/main/java/io/snabble/sdk/ui/scanner/SelfScanningView.java
Outdated
Show resolved
Hide resolved
cmaier
approved these changes
Dec 19, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deposit return vouchers can now be scanned. This means their accepted and a matching line item is added to the shopping cart. The violation handling has been integrated to ensure that the new feature behavous correctly.
This PR does not contain any ui.
APPS-1642 / APPS-1645
How to test?
Integrate this branch into an app usinng deposit return vouchers.
Test out at least the following.
Don't scan the zero amount or the redemption failed! We cannot handle it atm.
Definition of Done
App Tests
Testing