Add deposit return voucher states as part of the checkout process (Apps-2040) #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andle the state of drv's. E.g. if one of the drv's redemptions fails the checkout is aborted and the user is informed.
…into apps-2040-add-drv-to-checkout-process # Conflicts: # CHANGELOG.md # ui/src/main/res/values-de/strings.xml # ui/src/main/res/values/strings.xml
cmaier
suggested changes
Jan 6, 2025
cmaier
approved these changes
Jan 7, 2025
…into apps-2040-add-drv-to-checkout-process # Conflicts: # CHANGELOG.md # core/src/main/java/io/snabble/sdk/shoppingcart/ShoppingCart.kt # ui/src/main/res/values/strings.xml
…to-checkout-process
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
We can now track the state of deposit return vouchers in the checkout process. If a redemption failes, due to whatever reason, we receive a matching state in a new property
depositReturnVoucherswhich holds the state for each drv. The state is handled and the user is informed via a Dialog that the reffering deposit return voucher will be removed to proceed with the checkout, e.g. to try again without it.APPS-2040
How to test?
Integrate this branch into an app using drv's and scan the product linked in the issue. Add an additional item to get to a positive amount and checkout. -> The dialog should pop up after the checkout failed.
Definition of Done
App Tests
Testing