Made width and height required

snake · Aug 1, 2022 · 5f7904c · 5f7904c
1 parent 738f9d6
commit 5f7904c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/LtiDeepLinkResourceIcon.php b/src/LtiDeepLinkResourceIcon.php
@@ -8,14 +8,14 @@ class LtiDeepLinkResourceIcon
     private $width;
     private $height;
 
-    public function __construct(string $url, ?int $width = null, ?int $height = null)
+    public function __construct(string $url, int $width, int $height)
     {
         $this->url = $url;
         $this->width = $width;
         $this->height = $height;
     }
 
-    public static function new(string $url, ?int $width = null, ?int $height = null): LtiDeepLinkResourceIcon
+    public static function new(string $url, int $width, int $height): LtiDeepLinkResourceIcon
     {
         return new LtiDeepLinkResourceIcon($url, $width, $height);
     }
@@ -32,26 +32,26 @@ public function getUrl(): string
         return $this->url;
     }
 
-    public function setWidth(?int $width): LtiDeepLinkResourceIcon
+    public function setWidth(int $width): LtiDeepLinkResourceIcon
     {
         $this->width = $width;
 
         return $this;
     }
 
-    public function getWidth(): ?int
+    public function getWidth(): int
     {
         return $this->width;
     }
 
-    public function setHeight(?int $height): LtiDeepLinkResourceIcon
+    public function setHeight(int $height): LtiDeepLinkResourceIcon
     {
         $this->height = $height;
 
         return $this;
     }
 
-    public function getHeight(): ?int
+    public function getHeight(): int
     {
         return $this->height;
     }

diff --git a/tests/LtiDeepLinkResourceIconTest.php b/tests/LtiDeepLinkResourceIconTest.php
@@ -9,7 +9,7 @@ class LtiDeepLinkResourceIconTest extends TestCase
     public function setUp(): void
     {
         $this->imageUrl = 'https://example.com/image.png';
-        $this->deepLinkResourceIcon = new LtiDeepLinkResourceIcon($this->imageUrl);
+        $this->deepLinkResourceIcon = new LtiDeepLinkResourceIcon($this->imageUrl, 1, 2);
     }
 
     public function testItInstantiates()
@@ -19,7 +19,7 @@ public function testItInstantiates()
 
     public function testItCreatesANewInstance()
     {
-        $deepLinkResource = LtiDeepLinkResourceIcon::new($this->imageUrl);
+        $deepLinkResource = LtiDeepLinkResourceIcon::new($this->imageUrl, 100, 200);
 
         $this->assertInstanceOf(LtiDeepLinkResourceIcon::class, $deepLinkResource);
     }
@@ -44,7 +44,7 @@ public function testItGetsWidth()
     {
         $result = $this->deepLinkResourceIcon->getWidth();
 
-        $this->assertNull($result);
+        $this->assertEquals(1, $result);
     }
 
     public function testItSetsWidth()
@@ -60,7 +60,7 @@ public function testItGetsHeight()
     {
         $result = $this->deepLinkResourceIcon->getHeight();
 
-        $this->assertNull($result);
+        $this->assertEquals(2, $result);
     }
 
     public function testItSetsHeight()