Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: python #158
base: main
Are you sure you want to change the base?
fix: python #158
Changes from all commits
e1e892d
8b2a28a
70786dc
f8ceb9d
8f30ac8
91e0c97
4a5a453
3787145
9ffbd7b
90f0a55
99ba91e
e9d905e
697a4f1
4f35fa5
612a7ec
013cb83
c6f061f
4153c67
0b36482
eb3b42b
b7074ae
be6da61
4fe7d7f
e7ede28
0328110
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect usage of
{input}
in shell commandIn the
rule bwa_map
, the shell command uses{input}
directly, which may not correctly reference the input files as expected. Since{input}
is a list of input files, you should reference the individual elements explicitly.Apply this diff to fix the shell command:
This ensures that
bwa mem
receives the reference genome and the sample FASTQ file as separate arguments.📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Use named inputs in
bwa_map
for clarity and correctnessBy specifying named inputs, you can ensure the correct file order and improve the readability of your code. This is particularly important because
bwa mem
expects the reference genome and the read files in a specific order.Apply this diff to refactor the input and shell command:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assign a numeric value to
window_size
to prevent errorsThe variable
window_size
is currently set to...
, which is anEllipsis
object in Python. This will cause aTypeError
when used in numerical operations likenp.arange
. Assign a numeric value towindow_size
as suggested in the comments.Apply this diff to fix the error:
📝 Committable suggestion