Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parallel execution chapter #173

Merged
merged 17 commits into from
Jan 28, 2025
Merged

feat: parallel execution chapter #173

merged 17 commits into from
Jan 28, 2025

Conversation

cmeesters
Copy link
Member

@cmeesters cmeesters commented Nov 22, 2024

addresses issues #168 and #163

Summary by CodeRabbit

  • Configuration Updates

    • Updated course date in configuration file from September 2024 to January 2025
  • New Scripts

    • Added copy_script_mogonNHR.sh for cluster setup
    • Added install_conda.sh for Conda installation
  • New Workflow Examples

    • Added MPI example with Snakefile and C implementation for π calculation
  • Documentation

    • Expanded slides on parallel computing and Snakemake execution strategies

Copy link
Contributor

coderabbitai bot commented Nov 22, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request encompasses multiple changes across different files and scripts. The primary modifications include updating the course date in a configuration file, enhancing the rendering function for table of contents, adding new setup scripts for cluster and conda installation, introducing a new MPI example for calculating pi, and expanding LaTeX slides with content on parallel computing. The changes appear to be part of a broader effort to update tutorial materials and computational workflow scripts.

Changes

File Change Summary
config/config_Mainz_NHR.yaml Updated course date from "23.-27. September 2024" to "29.-30. January 2025"
render Modified find_and_replace_sections function:
- Changed min to max for upper boundary calculation
- Updated error handling with more specific logging
setup_creators/copy_script_mogonNHR.sh New script for setting up tutorial workflow on Mogon II cluster
setup_creators/install_conda.sh New script to download and install Miniforge from conda-forge
setup_creators/solutions/mpi_example/Snakefile Added Snakefile with rules for compiling and calculating pi using MPI
setup_creators/solutions/mpi_example/pi_MPI.c New MPI implementation for calculating pi using Monte Carlo method
slides/Snakemake_HPC_User_Creator_Combi.tex Added commented-out background package configuration
slides/creators/Parallel_Execution.tex Added new section on parallel computing and Snakemake

Sequence Diagram

sequenceDiagram
    participant User
    participant Cluster
    participant MPI Program
    
    User->>Cluster: Upload tutorial files
    User->>Cluster: Run installation script
    Cluster->>Cluster: Install Miniforge/Conda
    User->>Cluster: Compile MPI Program
    Cluster->>MPI Program: Compile pi_MPI.c
    User->>Cluster: Execute MPI Program
    Cluster->>MPI Program: Calculate Pi
    MPI Program-->>Cluster: Return Pi Calculation
Loading

Possibly related PRs

Suggested reviewers

  • brand-fabian

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 073eb60 and a02bc62.

⛔ Files ignored due to path filters (1)
  • images/humor/DALLE_runners.jpg is excluded by !**/*.jpg
📒 Files selected for processing (8)
  • config/config_Mainz_NHR.yaml (1 hunks)
  • render (1 hunks)
  • setup_creators/copy_script_mogonNHR.sh (1 hunks)
  • setup_creators/install_conda.sh (1 hunks)
  • setup_creators/solutions/mpi_example/Snakefile (1 hunks)
  • setup_creators/solutions/mpi_example/pi_MPI.c (1 hunks)
  • slides/Snakemake_HPC_User_Creator_Combi.tex (1 hunks)
  • slides/creators/Parallel_Execution.tex (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Artifacts

@cmeesters cmeesters marked this pull request as ready for review January 28, 2025 21:51
@cmeesters cmeesters merged commit 7d4fccc into main Jan 28, 2025
5 of 6 checks passed
@cmeesters cmeesters deleted the feat/parallel_execution branch January 28, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant