fix: typo, remove unused time call

[pdimens]

The example snakemake rule had two issues:

1. under resources the parameter was provided as mem_mem and should be mem_mb
2. under resources the parameter time is not used in wrapper.py and was thus removed

QC

• I confirm that I have followed the documentation for contributing to snakemake-wrappers.

While the contributions guidelines are more extensive, please particularly ensure that:

• test.py was updated to call any added or updated example rules in a Snakefile
• input: and output: file paths in the rules can be chosen arbitrarily
• wherever possible, command line arguments are inferred and set automatically (e.g. based on file extensions in input: or output:)
• temporary files are either written to a unique hidden folder in the working directory, or (better) stored where the Python function tempfile.gettempdir() points to
• the meta.yaml contains a link to the documentation of the respective tool or command under url:
• conda environments use a minimal amount of channels and packages, in recommended ordering

Summary by CodeRabbit

• Chores
  • Removed trailing commas in multiple sections for improved syntax.
  • Updated resource key from mem_mem to mem_mb for clarity.

[coderabbitai]

Walkthrough

The changes in the Snakefile for the Metaspades assembly process involve syntax modifications, primarily the removal of trailing commas in various sections, which does not alter functionality. Additionally, the key for memory resources has been updated from mem_mem to mem_mb, indicating a correction. The structure of the download_test_reads rule remains unchanged.

Changes

File Path	Change Summary
bio/spades/metaspades/test/Snakefile	Removed trailing commas from input, output, params, and log sections. Updated key from mem_mem to mem_mb in resources.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Snakefile
    participant Metaspades

    User->>Snakefile: Trigger workflow
    Snakefile->>Metaspades: Run assembly process
    Metaspades-->>Snakefile: Return results
    Snakefile-->>User: Provide output

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between bb4c6dc and 5fc5bc9.

📒 Files selected for processing (1)

• bio/spades/metaspades/test/Snakefile (1 hunks)

🧰 Additional context used

🔇 Additional comments (6)

bio/spades/metaspades/test/Snakefile (6)

6-6: LGTM: Improved syntax in input section.

The removal of the trailing comma in the reads list improves code style without affecting functionality. This change aligns with PEP 8 guidelines for Python.

---

10-10: LGTM: Consistent syntax improvement in output section.

The removal of the trailing comma after the dir declaration maintains consistency with the style changes made in the input section. This change improves readability without altering functionality.

---

16-16: LGTM: Consistent syntax improvement in params section.

The removal of the trailing comma after the extra parameter in the params section maintains consistency with the style changes made in previous sections. This change improves overall code style without affecting functionality.

---

18-18: LGTM: Consistent syntax improvement in log section.

The removal of the trailing comma after the log file declaration in the log section maintains consistency with the style changes made in previous sections. This change contributes to a more uniform code style throughout the file.

---

21-21: Excellent fix: Corrected memory resource specification.

The change from mem_mem to mem_mb is a crucial fix that accurately specifies the memory resource in megabytes. This correction aligns with the PR objectives and resolves the typo mentioned in the PR summary. It enhances the clarity and correctness of the resource allocation for the Metaspades assembly process.

---

Line range hint 1-34: Overall assessment: Excellent improvements and bug fix.

The changes in this file successfully address the PR objectives:

1. The typo in the resources section has been corrected, changing mem_mem to mem_mb.
2. Consistent style improvements have been made throughout the file by removing trailing commas.

These changes enhance code readability and correct the resource specification without altering the functionality of the Snakefile. The download_test_reads rule remains unchanged, as expected.

Great job on these improvements!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.