Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187436627 registration only textbox - look at last #376

Merged

Conversation

tiffanylamm
Copy link
Contributor

Pivotal Tracker Link

What this PR does:

This pull request implements snapcon issue #234. I added a message to registered users on a conferences splash page right above a conferences description. I also removed the warning message above the currency conversion admin page that says don't use because this has not been implemented. yet.

Include screenshots, videos, etc.

Screenshot 2024-04-27 at 12 08 05 AM

Who authored this PR?

@tiffanylamm

How should this PR be tested?

I wrote feature tests checking to make sure the message disappears for a non registered user and appeared for registered user.

Are there any complications to deploying this?

This requires a migration to add a new field registered_attendees_message to the conference model.

Checklist:

  • Has this been deployed to a staging environment or reviewed by a customer?
  • Tag someone for code review (either a coach / team member)
  • I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay)

@cycomachead cycomachead merged commit 0e26688 into snap-cloud:main Aug 1, 2024
10 of 11 checks passed
@cycomachead cycomachead deleted the 187436627-registration-only-textbox branch August 1, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants