Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only promote revisions mentioned in the call for testing #16

Merged

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented Dec 5, 2023

This PR aims to ensure that the promote-to-stable action will only promote revisions that are explicitly mentioned for promotion in the call-for-testing issue.

It works by parsing the /promote <rev>,... stable done command example in the call for testing issue.

@jnsgruk jnsgruk force-pushed the validate-promote-revisions branch 7 times, most recently from b2c3e04 to cf72a09 Compare December 5, 2023 14:33
@jnsgruk jnsgruk marked this pull request as ready for review December 5, 2023 14:34
Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merlijn-sebrechts merlijn-sebrechts merged commit e14a051 into snapcrafters:main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants