Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make bot name/email configurable #40

Merged
merged 2 commits into from
May 29, 2024
Merged

feat: make bot name/email configurable #40

merged 2 commits into from
May 29, 2024

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented May 29, 2024

Fixes #39

This should make the actions more reusable by people other than Snapcrafters.

Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

TIL that nest inputs in GitHub Actions are still an open feature request. I'll test out the bot-name and bot-email later this morning on the Slurm snap.

@NucciTheBoss NucciTheBoss merged commit 198381f into main May 29, 2024
1 check passed
NucciTheBoss added a commit to charmed-hpc/slurm-snap that referenced this pull request May 29, 2024
Updated CI action so that we can set a custom publisher
rather than be required to use the `Snapcrafters Bot`
account to tag releases + sync upstream versions of code:
snapcrafters/ci#40

When new candidate versions of the slurm snap are published,
a tag for each architecture + revision will be created by the
Ubuntu HPC bot account.

Signed-off-by: Jason C. Nucciarone <[email protected]>
NucciTheBoss added a commit to charmed-hpc/slurm-snap that referenced this pull request May 29, 2024
Updated CI action so that we can set a custom publisher
rather than be required to use the `Snapcrafters Bot`
account to tag releases + sync upstream versions of code:
snapcrafters/ci#40

When new candidate versions of the slurm snap are published,
a tag for each architecture + revision will be created by the
Ubuntu HPC bot account.

Signed-off-by: Jason C. Nucciarone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Allow a different author to create tags when releasing a snap to the candidate channel
2 participants